Closed
Bug 1063515
Opened 10 years ago
Closed 10 years ago
unittest alarm_test.js Alarm Test Date handling getNextAlarmFireTime: Error: expected 1 to equal 5
Categories
(Firefox OS Graveyard :: Gaia::Clock, defect)
Firefox OS Graveyard
Gaia::Clock
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sv99, Unassigned)
Details
Attachments
(2 files)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20140902004002
Steps to reproduce:
Problem in my MAC OSX timezone Europe/Moscow UTC+4
clock/test/unit/alarm_test.js
19: suite('Date handling', function() {
var now = new Date(1398387324081); // thursday
now -> Date 2014-04-25T00:55:24.081Z
now.getTimezoneOffset() -> -240
in my time zone this is not thursday -> this is friday!!
Attachment #8484949 -
Flags: review?(m)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8484949 [details] [diff] [review] alarm_test.diff Review of attachment 8484949 [details] [diff] [review]: ----------------------------------------------------------------- aha, good catch!
Attachment #8484949 -
Flags: review?(m) → review+
Attachment #8498756 -
Flags: review?(m)
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8498756 [details] [review] Link to PR (rebased) Thanks! landed in master, r=mcav: https://github.com/mozilla-b2g/gaia/commit/309ac9a90af199c8b8e67cbbbe16e1d4c7854970
Attachment #8498756 -
Flags: review?(m) → review+
|
|
||
Updated•10 years ago
|
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•