1063585 - about:accounts Sync Template requires a replacement logo

Status: RESOLVED FIXED

(Snippets Graveyard :: General, defect)

Description

[Osmose [:osmose, :mkelly]]

The about:accounts Sync template (https://snippets.mozilla.com/admin/base/snippettemplate/20/) shows a blank logo when a replacement isn't provided. Currently, this means that when jcollings wants to send an about:accounts snippet without a replacement logo, she sends the Firefox logo, which is unnecessary data and also may not work on hi-DPI environments.

There's a few solutions here:

1. Add another template that does about:accounts stuff but doesn't swap the logo.
2. Alter the current template to support not replacing the logo (this might require services changes to support removing an image field that has already been filled, or adding a checkbox input for template variables).
3. Alter the base snippet JS to detect all links with "about:accounts" or something as the href, and trigger the event instead of following the link.

I think #3 is the right solution as it allows us to get rid of custom templates for these snippets and instead lets us re-use existing logo swap and simple snippet templates.

Comment 1

[Giorgos Logiotatidis [:giorgos]]

I agree that #3 is the right solution. I'll start working towards this.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/snippets-service

https://github.com/mozilla/snippets-service/commit/231b47cff04214524c9004772834d01c9f16142f
[fix bug 1063585] Make 'about:accounts' snippet links to trigger showFirefoxAccounts Event.

https://github.com/mozilla/snippets-service/commit/d3292b88e0225f9f660e78cd8853a3f11854628d
Merge pull request #62 from glogiotatidis/clone-2

[fix bug 1063585] Make 'about:accounts' snippet links to trigger showFirefoxAccounts Event.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/snippets-service

https://github.com/mozilla/snippets-service/commit/c7a71ebba7ffd23893b79c3d9f0ab1e272683a2e
[bug 1063585] Lowercase tagName before comparing with 'a'.

https://github.com/mozilla/snippets-service/commit/6741a498c7d97e045755a4983900ca83bf2f3c00
Merge pull request #63 from glogiotatidis/master

[bug 1063585] Lowercase tagName before comparing with 'a'.

Comment 4

[Osmose [:osmose, :mkelly]]

Reopening because the snippets that got updated after we pushed the about:accounts magic are still using logo replacement templates when they should be simple snippets.

Comment 5

[Giorgos Logiotatidis [:giorgos]]

The logo replacement templates link the big logo as well (the simple snippet does not). I didn't change the template so I don't mess with stats or a/b testing between the two snippet versions.  

msmiley or wbowden: do we care if the big logo is clickable in this snippet?

https://snippets.mozilla.com/admin/base/snippet/4522/

Comment 6

[Osmose [:osmose, :mkelly]]

That's fair, although I don't think we've ever made the logo clickable without changing it as normally it isn't clickable.

Comment 7

[Winston Bowden]

In snippet 4522, the logo should probably "not" be clickable.

Comment 8

[Giorgos Logiotatidis [:giorgos]]

Changed all 20 SyncSignUp_* snippets to "Simple Snippet w/ Icon URL"