106379 - NSS Fails to build under ARM Linux

Status: RESOLVED FIXED

(NSS :: Build, defect, P2)

Description

[Mark Crichton]

Mozilla's NSS Build setup fails to recognize an OS_TEST of "armv4l".  Since 
there is no explicit test for it in Linux.mk, it will default to x86.

And, trust me, it's quite entertaining to watch arm-linux-as munch on x86 
code...

Simple fix is to add the following lines in the coreconf/Linux.mk file:

ifeq ($(OS_TEST),armv4l)
        OS_REL_CFLAGS   = -DLINUX1_2 -D_XOPEN_SOURCE
        CPU_ARCH        = armv4l

However, since you can have different ARM types (forst 2 are version, last for 
endian IIRC), there should be a smarter test.  However, since I think only 
recent ARMs can really chew Mozilla, armv4l might be best (it represents most 
Strongarms...dunno about the new XScale.  My ARM knowledge isn't great).

Comment 1

[Wan-Teh Chang]

Thanks for the bug report.  NSS has never been compiled
on Linux/arm.  I will attach a patch for you to try.
(This patch is copied from the old NSPR build system.)

Comment 2

[Wan-Teh Chang]

Attachment: Proposed patch.

Comment 3

[Mark Crichton]

Builds here.

Can't do a running test.  There appears to be some other possible bugs floating 
around somewhere.

Comment 4

[Wan-Teh Chang]

The patch has been checked in on the tip and
the NSS_3_3_BRANCH.  The NSS_CLIENT_TAG has
been moved.