1063957 - Menu listing device access by websites empty if string for device set missing

Status: VERIFIED FIXED

(Firefox :: Keyboard Navigation, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox Nightly and Aurora 20140906 on Windows 8.1

If a user grants a website access to e.g. a windows and a camera, the menu listing the device access by websites remains empty because the string needed for that permission is missing.

NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.formatStringFromName] XStringBundle:37

Steps to reproduce:
1. Set media.getusermedia.screensharing.allowed_domains to mozilla.github.io,queze.net
2. Visit http://queze.net/goinfre/ff_gum_test.html
3. Click on 'Window then Video'.
4. Grant access to a window and a video source.
5. Open the menu which should list the access permissions.
Actual result: It is empty and the error thrown.

Bug 1043372 added strings for some sets of device permissions, but the combination window + camera is not in these strings.

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

Unfortunate that we didn't catch this before the merge of 34 to aurora, but sharing the camera and a {screen,window,app} without sharing the microphone at the same time is such an edge case that I don't think it's worth trying to figure out a way to fix this on aurora.

Comment 2

[:Gijs (he/him)]

Comment on attachment 8486390 [details] [diff] [review]
Patch

Review of attachment 8486390 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Could do a try catch at least on Aurora so we don't have an empty menu, which kind of sucks?

Comment 3

[Florian Quèze [:florian]]

(In reply to :Gijs Kruitbosch from comment #2)

> Could do a try catch at least on Aurora so we don't have an empty menu,
> which kind of sucks?

If this was the only item, we would likely still have an empty menu.

Comment 4

[:Gijs (he/him)]

(In reply to Florian Quèze [:florian] [:flo] from comment #3)
> (In reply to :Gijs Kruitbosch from comment #2)
> 
> > Could do a try catch at least on Aurora so we don't have an empty menu,
> > which kind of sucks?
> 
> If this was the only item, we would likely still have an empty menu.

Hrmpf. Can we lie and make camera + something else imply microphone is shared as well? I'd rather have the code be broken that way than not showing anything...

Comment 5

[Marco Mucci [:MarcoM]]

Hi Florian, is this bug still a priority for IT 35.2 or can it be removed?

Comment 6

[Florian Quèze [:florian]]

(In reply to Marco Mucci [:MarcoM] from comment #5)
> Hi Florian, is this bug still a priority for IT 35.2 or can it be removed?

The patch here is ready, I just need to do a check-in.

Comment 7

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/c66eb4cb7d29

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c66eb4cb7d29

Comment 9

[Florian Quèze [:florian]]

(In reply to Archaeopteryx [:aryx] from comment #0)

> Steps to reproduce:

> 2. Visit http://queze.net/goinfre/ff_gum_test.html

Screen sharing now requires https. Use https://people.mozilla.org/~fqueze2/webrtc/ff_gum_test.html instead.

Comment 10

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 35.0a1 (2014-09-06) using Windows 8.1 x64.

Verified fixed on Latest Firefox 35.0a2 (2014-11-24) using Windows 8.1 x64.