1064132 - Listen for wake_notification to evaluate whether to sync

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Richard Newman [:rnewman]]

Follow-on from Bug 1064122.

The idle service isn't enough.

This won't work on Linux, but ¯\_(ツ)_/¯

Comment 1

[Richard Newman [:rnewman]]

Attachment: Listen for wake_notification to evaluate whether to sync. v1

This ought to work.

Comment 2

[Richard Newman [:rnewman]]

https://tbpl.mozilla.org/?tree=Try&rev=99b9b1e31ac6

Comment 3

[Richard Newman [:rnewman]]

Attachment: Listen for wake_notification to evaluate whether to sync. v1

(Feel free to treat this as f?; bzexport screws up feedback requests.)

xpcshell tests pass, though obviously there aren't new ones.

Not yet manually tested.

I'm open to suggestions about whether we should wait a while after waking to make sure the network is up.

Comment 4

[Richard Newman [:rnewman]]

Attachment: Listen for wake_notification to evaluate whether to sync. v2

Now with observer added in the correct place!

Comment 5

[Richard Newman [:rnewman]]

Manually tested. ++

Comment 6

[James Bonacci [:jbonacci]]

Will this need to be looked at from the desktop as well as the mobile client?

Comment 7

[Richard Newman [:rnewman]]

This is a 100% desktop-only change.

Comment 8

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8486594 [details] [diff] [review]
Listen for wake_notification to evaluate whether to sync. v2

Review of attachment 8486594 [details] [diff] [review]:
-----------------------------------------------------------------

TIL there is a wake_notification, but I like it :)

Comment 9

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/f5b0a8afb324

Comment 10

[Richard Newman [:rnewman]]

Ready for QA on fx-team in 3, 2… :D

Comment 11

[James Bonacci [:jbonacci]]

Removing my flag on the Whiteboard so I don't have to hear from the whiners...

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f5b0a8afb324