1064145 - "No module named manifest" with web-platform-tests-update

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Karl Tomlinson (:karlt)]

Following instructions at 
https://github.com/mozilla/gecko-dev/blob/master/testing/web-platform/README.md#autogenerating-expectation-data

and running the command
  ./mach web-platform-tests-update --no-check-clean wpt.with.mse

yields

git rev-parse --show-cdup
fatal: Not a git repository (or any parent up to mount point /mnt/ssd1)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
{'cwd': u'/mnt/ssd1/karl/moz/dev/testing/web-platform/sync'}

git rev-parse --show-cdup
fatal: Not a git repository (or any parent up to mount point /mnt/ssd1)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
{'cwd': u'/mnt/ssd1/karl/moz/dev/testing/web-platform/sync'}

Traceback (most recent call last):
  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/harness/wptrunner/update.py", line 305, in update_metadata
    ignore_existing=ignore_existing)
  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/harness/wptrunner/metadata.py", line 49, in update_expected
    manifest = load_test_manifest(test_root, metadata_root)
  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/harness/wptrunner/metadata.py", line 31, in load_test_manifest
    do_test_relative_imports(test_root)
  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/harness/wptrunner/metadata.py", line 75, in do_test_relative_imports
    import manifest
ImportError: No module named manifest
Error running mach:

    ['web-platform-tests-update', '--no-check-clean', 'wpt.with.mse']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

ImportError: No module named manifest

  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/mach_commands.py", line 120, in update_web_platform_tests
    return wpt_updater.run_update(**params)
  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/mach_commands.py", line 78, in run_update
    update.run_update(**kwargs)
  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/harness/wptrunner/update.py", line 367, in run_update
    kwargs["run_log"], kwargs["ignore_existing"])
  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/harness/wptrunner/update.py", line 305, in update_metadata
    ignore_existing=ignore_existing)
  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/harness/wptrunner/metadata.py", line 49, in update_expected
    manifest = load_test_manifest(test_root, metadata_root)
  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/harness/wptrunner/metadata.py", line 31, in load_test_manifest
    do_test_relative_imports(test_root)
  File "/mnt/ssd1/karl/moz/dev/testing/web-platform/harness/wptrunner/metadata.py", line 75, in do_test_relative_imports
    import manifest

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: distinguish between sync and test paths in metadata.update_expected()

Comment 2

[James Graham [:jgraham]]

Comment on attachment 8485604 [details] [diff] [review]
distinguish between sync and test paths in metadata.update_expected()

Review of attachment 8485604 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch; it basically looks right, but needs to be fixed upstream, so I adapted it a little and submitted https://critic.hoppipolla.co.uk/r/2533 to make the metadata work without a local repository.

Comment 4

[James Graham [:jgraham]]

This landed upstream a while ago.