1064397 - CardsHelper.getIconURIForApp returns bad url given an absolute, off-origin URL

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Sam Foster [:sfoster] (he/him)]

e.me apps return a .icon url like "http://api.everything.me/partners/1.0/Icon/get?id=26&iconFormat=20&apiKey=...", which is getting badly resolved/concat-ed with the app origin to produce "http://wikipedia.flyapps.mehttp://api.everything.me/partners/1.0/Icon/get?id=26&iconFormat=20&apiKey=..."

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Fix handling for absolute icon URLs used by e.me app windows

Rather than assuming all non-data URIs are relative paths, this change explicitly checks for leading '/' - which is the only expected and handled case in this block. 

The getOriginObject a) wasnt used outside this file, and b) was really just returning a URL-like hash with protocol etc. properties. So I got rid of it in favour of using URL.

Comment 2

[Etienne Segonzac (:etienne)]

Comment on attachment 8485851 [details] [review]
Fix handling for absolute icon URLs used by e.me app windows

lgtm :)

Comment 3

[Sam Foster [:sfoster] (he/him)]

Merged to master: https://github.com/mozilla-b2g/gaia/commit/cebf9e694d4536fbc4012a1fe1f60d31adf8e628
Original commit: https://github.com/mozilla-b2g/gaia/commit/0294015fca59f4f8d08ae8c946c7a3fccce32310

..but I was looking at the wrong tbpl results. Will backout and try again shortly.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Backed out: https://github.com/mozilla-b2g/gaia/commit/46e35fd6adc8f89d1b058ff84312cb38242c4658

Comment 5

[Sam Foster [:sfoster] (he/him)]

Attachment: Fix handling of absolute icon urls in CardsHelper (redux)

Carrying Etienne's r+, this PR fixes unit tests by handling empty src urls which get passed in the tests.

Comment 6

[Sam Foster [:sfoster] (he/him)]

Nice green Gaia-Try run: https://tbpl.mozilla.org/?rev=b36e24acdc6de8516d6cff699e521a14cd6f03bf&tree=Gaia-Try

Merged: https://github.com/mozilla-b2g/gaia/commit/fc87b188d69e7c24871a1d0ea1ab2fb50a0ac43e
Commit: https://github.com/mozilla-b2g/gaia/commit/28ac34de705dc65ddb833a071381468907896273