1064486 - "Name" and "Accepting new members" strings is cannot be localized

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[YF (Yang)]

These strings not in po files.

Examples:
https://mozillians.org/en-US/groups/add/
https://mozillians.org/zh-CN/groups/add/

Comment 1

[William Reynolds [:williamr]]

Thanks for submitting this bug YF! Good find.

Comment 2

[Jérémy Dagorn]

I would like to take this bug, as it would help me make my way in the codebase. Is it OK?

Comment 3

[Tasos Katsoulas [:tasos]]

Of course it is :)
Thanks for offering to help. I am assigning this bug to you.
You can find useful information on how to setup your local environment here [0]. Also if you need additional help you can always ask at #commtools on irc.

[0] http://mozillians.readthedocs.org/en/latest/

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/1e3c5c7cdcff38a5c4d50ea118e6e37ae8ab6ce1
[Fix bug 1064486] Localize strings in add group page.

https://github.com/mozilla/mozillians/commit/efd6cc811d786ecff25826232e5cb5b918d39813
Merge pull request #1126 from johngian/pr-1123

[Fix bug 1064486] Localize strings in add group page.

Comment 5

[Teri Charles [:tericharles]]

Browsers:
-Firefox/Mac
-Chrome/Mac

I can verify the following for this bug:

1. My thinking for this bug is that the translation team will need to verify that they will now see 'Name' and 'Accepting new members' fields translated when they use they correct translation file. I am unable to see the fields translated, but I believe it's because I don't have the correct file perhaps.

2. In addition, I noticed that the 'IRC' field is also not getting translated, so it would be good if that field is fixed as well. I will file a new bug for this.

3. For this bug, I can verify that the following has been changed in the code
https://github.com/mozilla/mozillians/commit/1e3c5c7cdcff38a5c4d50ea118e6e37ae8ab6ce1#diff-9e19e76fd73ce35e4918a3fc9bc96cbbR76
{% if user.userprofile.is_manager %}
- <h2>Admin Settings</h2>
+ <h2>{{ _('Admin Settings') }}</h2>

https://github.com/mozilla/mozillians/commit/1e3c5c7cdcff38a5c4d50ea118e6e37ae8ab6ce1
class GroupBase(models.Model):
- name = models.CharField(db_index=True, max_length=50, unique=True)
+ name = models.CharField(db_index=True, max_length=50,
+ unique=True, verbose_name=_lazy(u'Name'))
url = models.SlugField(blank=True)
objects = GroupBaseManager()
@@ -176,6 +177,7 @@ class Group(GroupBase):
default='', blank=True)
members_can_leave = models.BooleanField(default=True)
accepting_new_members = models.CharField(
+ verbose_name=_lazy(u'Accepting new members'),
choices=(
('yes', _lazy(u'Yes')),
('by_request', _lazy(u'By request')),

Comment 6

[Matt Brandt [:mbrandt]]

 Bumping to verified per comment 5 -- YF are able to verify that this meets your needs?

Comment 7

[Jérémy Dagorn]

Anything I should do then?

Comment 8

[YF (Yang)]

I don't see it been updated at https://svn.mozilla.org/projects/l10n-misc/trunk/mozillians/locales/en_US/LC_MESSAGES/messages.po.

These still can not be localized via Mozilla Verbatim at the moment.

Comment 9

[Jérémy Dagorn]

I am the one working on this bug. I committed the changes. Is there anything I should do? or ask someone to run a script to make them appear on the .po file?

Comment 10

[Jérémy Dagorn]

Edit: I know that locally I was running a script that made them appear in the .po file and was able to play with the translation, verifying that it worked. http://mozillians.readthedocs.org/en/latest/internationalization.html#managing-strings

Comment 11

[John Giannelos [:nemo-yiannis]]

I merged some new strings and Verbatim is up-to-date. These strings should be available for localization now.