1064705 - nestegg_read_packet returns EOS if reading the block_duration or discard_padding hits EOS

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

nestegg_read_packet successfully reads the final block, but if it hits an EOS on a call to ne_read_block_duration, ne_read_discard_padding, or ne_read_block_additions it will return EOS and WebMReader will not be able to use the final packet.

This is a regression from any/all of the following three nestegg commits:
https://github.com/kinetiknz/nestegg/commit/d46a8605
https://github.com/kinetiknz/nestegg/commit/1aae70ca
https://github.com/kinetiknz/nestegg/commit/dcd18d1f

Comment 1

[Matthew Gregan [:kinetik]]

Should be fixed by https://github.com/kinetiknz/nestegg/commit/fe78d485aabf8339c9d2e033a0d37436c33370d9, but need to test Opus playback for regressions.

Comment 2

[Matthew Gregan [:kinetik]]

https://tbpl.mozilla.org/?tree=Try&rev=68e746d26902

Comment 3

[Matthew Gregan [:kinetik]]

Attachment: Don't treat EOS as fatal when reading optional block subelements in nestegg_read_packet

Comment 4

[Matthew Gregan [:kinetik]]

Comment on attachment 8486805 [details] [diff] [review]
Don't treat EOS as fatal when reading optional block subelements in nestegg_read_packet

Green on try.

Comment 5

[Matthew Gregan [:kinetik]]

(In reply to Matthew Gregan [:kinetik] from comment #4)
> Green on try.

But this + bug 1064699 is orange because the tests check v.duration == 4.0 but with both patches applied we end up with a duration of 4.001 (root cause is bug 1065207).  seek.webm's frame rate is 30 FPS and the timecode durations alternate between 33ms and 34ms.  The last frame has a start time of 3.967 ans should be 33ms long, but we calculate it as 34ms because the preceding timecode was 3.933 (= 34ms duration).

Comment 6

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/170ce237e4a0

Comment 7

[Matthew Gregan [:kinetik]]

(In reply to Matthew Gregan [:kinetik] from comment #6)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/170ce237e4a0

I tweaked the tests for now, since this fix is more important.  The tweak references bug 1065207.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/170ce237e4a0

Comment 9

[Carsten Book [:Tomcat]]

sorry had to back this out for test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=48178648&tree=Mozilla-Inbound

Comment 10

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bbeb7caa2cda

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bbeb7caa2cda