1064973 - Add FxAccounts xpcshell tests to testing/xpcshell/xpcshell_b2g.ini

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FxA, defect)

Comment 1

[Sam Penrose]

Attachment: 1064973-add-fxaccounts.patch

Hi Ryan!

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1064606#c3 we would like to get the fxaccounts xpcshell tests run regularly. Please let me know if this is less simple than it seems.

Thanks,
Sam

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8486517 [details] [diff] [review]
1064973-add-fxaccounts.patch

Review of attachment 8486517 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, should be that simple. r+ assuming it's green on Try :)

Note that B2G debug xpcshell is incredibly flaky at the moment and hidden by default. You'll need to add &showall=1 to the TBPL URL to see their results. At least make sure they aren't perma-failing there (but don't expect the runs to be otherwise-green).

Comment 3

[Sam Penrose]

Thanks Ryan!

https://tbpl.mozilla.org/?tree=Try&rev=325a4ebd0d44&showall=1

Comment 4

[Sam Penrose]

The two errors in the try are real, and fixed by these patches:

https://bugzilla.mozilla.org/show_bug.cgi?id=1064606
https://bugzilla.mozilla.org/show_bug.cgi?id=1065477

Comment 5

[Carsten Book [:Tomcat]]

(In reply to Sam Penrose from comment #4)
> The two errors in the try are real, and fixed by these patches:
> 
> https://bugzilla.mozilla.org/show_bug.cgi?id=1064606
> https://bugzilla.mozilla.org/show_bug.cgi?id=1065477

Hi Sam, so we need to wait till bug 1065477 has r+ right ? (and so ready to checkin to unbreak the test)

Comment 6

[Sam Penrose]

Hi Carsten: bug 1065477 is now r+.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/65e0d2b2ea99

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/65e0d2b2ea99