Closed
Bug 1065049
Opened 10 years ago
Closed 10 years ago
No process name for the GMP process in the mochitest log
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: mccr8, Assigned: mccr8)
Details
Attachments
(1 file)
1.15 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
When things get added to the log, like NS_WARNING output, it adds information about the process. For a content child process, it prints out that it is a child process: 17:51:19 INFO - [Child 1802] WARNING: ... Similarly in the parent process. However, for the geckomediaplugin, it just does: 17:56:48 INFO - [2257] WARNING: ... The Gecko Media Plugin stuff is a new kind of process, so presumably there just needs to be a new case added somewhere. It would make interpreting the logs easier. I don't actually know where this code lives that produces that process output.
Assignee | ||
Comment 1•10 years ago
|
||
automationutils stuff uses geckomediaplugin as the name, but maybe just GMP here would be good, so the lines don't all get too long.
Comment 2•10 years ago
|
||
I think you just need a call like this in the GMPChild: http://hg.mozilla.org/mozilla-central/annotate/4d1793da0b96/dom/ipc/ContentChild.cpp#l524
Assignee | ||
Updated•10 years ago
|
Component: Mochitest → Video/Audio
Product: Testing → Core
Assignee | ||
Comment 3•10 years ago
|
||
Ah, great, I would not have guessed that.
Assignee: nobody → continuation
Assignee | ||
Comment 4•10 years ago
|
||
I confirmed that this works, though it looks like some of the very early "WARNING: XPCOM objects created/destroyed from static ctor/dtor" spam doesn't get annotated. try run: https://tbpl.mozilla.org/?tree=Try&rev=929b76bb71f5
Attachment #8487428 -
Flags: review?(rjesup)
Updated•10 years ago
|
Attachment #8487428 -
Flags: review?(rjesup) → review+
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b58fabead3f9
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b58fabead3f9
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•10 years ago
|
Flags: qe-verify+
Updated•10 years ago
|
Flags: qe-verify+ → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•