Closed
Bug 1065477
Opened 10 years ago
Closed 10 years ago
Bind FxAccountsProfileClientError to global "this" for B2G
Categories
(Firefox :: Firefox Accounts, defect)
Tracking
()
RESOLVED
FIXED
Firefox 35
People
(Reporter: spenrose, Assigned: spenrose)
Details
Attachments
(1 file, 1 obsolete file)
1.15 KB,
patch
|
Details | Diff | Splinter Review |
This declaration in FxAccountsProfileClient.jsm: var FxAccountsProfileClientError = function (details) { does not export the symbol on B2G.
Assignee | ||
Comment 1•10 years ago
|
||
Fernando this is another nit exposed by running xpcshell-test. Thanks!
Attachment #8487305 -
Flags: review?(ferjmoreno)
Comment 2•10 years ago
|
||
Comment on attachment 8487305 [details] [diff] [review] 1065477-use-this.patch Review of attachment 8487305 [details] [diff] [review]: ----------------------------------------------------------------- Thanks Sam! ::: services/fxaccounts/FxAccountsProfileClient.jsm @@ +150,5 @@ > * @param {String|null} [details.message] > * Error message > * @constructor > */ > +this.FxAccountsProfileClientError = function (details) { nit: no space between "function" and the parenthesis, please.
Attachment #8487305 -
Flags: review?(ferjmoreno) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8487305 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/cbf008a9deb1
Flags: in-testsuite+
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cbf008a9deb1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•7 years ago
|
Product: Core → Firefox
Updated•7 years ago
|
Target Milestone: mozilla35 → Firefox 35
You need to log in
before you can comment on or make changes to this bug.
Description
•