1065526 - Add a Copy() method to Moz2D Matrix

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

As discussed on IRC, let's add a Copy() method to Matrix to allow:

  dt->SetTransform(Matrix(dt->GetTransform()).Foo(...));

to be written as:

  dt->SetTransform(dt->GetTransform().Copy().Foo(...));

which I think makes it marginally easier to spot that we're modifying the existing transform. This is a really common usage pattern so I think it's worth it, although it may seem a little unnecessary to some.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch Moz2D Matrix

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: patch gfxMatrix

Comment 3

[Bas Schouten (:bas.schouten)]

Comment on attachment 8487432 [details] [diff] [review]
patch Moz2D Matrix

Review of attachment 8487432 [details] [diff] [review]:
-----------------------------------------------------------------

I wonder if we should use FORCEINLINE if we're going to use this a lot.

Comment 4

[Jonathan Watt [:jwatt]]

Comment on attachment 8487433 [details] [diff] [review]
patch gfxMatrix

I'll add MOZ_ALWAYS_INLINE to both patches.

Comment 5

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f758f49893e5
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c30f59cc34b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f758f49893e5
https://hg.mozilla.org/mozilla-central/rev/1c30f59cc34b