1065977 - Uplift recent PSL changes to aurora and beta

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Gervase Markham [:gerv]]

As in bug 1033340 and bug 1024964, we'd like to uplift recent PSL changes to aurora, beta and ESR 31, to accelerate adoption. 

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1 for mozilla-aurora

This patch looks large, but it's because the new gTLDs were alphabetized as a side effect of a new, more reliable method of generating the list. (They were previously in order of addition.)

Approval Request Comment
[Feature/regressing bug #]: PSL
[User impact if declined]: Some new gTLDs may have unexpected behaviour.
[Describe test coverage new/current, TBPL]: Baked on trunk.
[Risks and why]: Very low risk; we have made updates like this before.
[String/UUID change made/needed]: None.

Gerv

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.1 for mozilla-beta

Approval Request Comment - see previous attachment.

Gerv

Comment 3

[Gervase Markham [:gerv]]

Attachment: Patch v.1 for mozilla-esr31

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
See above - low-risk update to data file shipped with the product.

Gerv

Comment 4

[Gervase Markham [:gerv]]

lmandel asked for details of which bugs this uplift request relates to. Here's a list, with their m-c checkin dates and details of which branches they need to be applied to. (The last uplift was on 13th June so anything checked in before that is already on all branches.)

Needed on aurora, beta and ESR:

Bug 1061266 - New TLD additions for gTLDs contracted with ICANN from 2014-07-25 to 2014-09-01
m-c: 2014-09-04 

Bug 1061264 - Add service.gov.uk to the PSL
m-c: 2014-09-03

Needed on beta and ESR:

Bug 1051892 - Fix comments in PSL
m-c: 2014-08-13

Bug 1051875 - Update PSL for nom.br
m-c: 2014-08-13

Bug 1041035 - Update subTLDs for .tr
m-c: 2014-08-13

Bug 1040729 - Add yolasite.com to PSL
m-c: 2014-08-13

Bug 1037901 - Add flynnhub.com to PSL
m-c: 2014-08-13

Bug 1028347 - Remove k12.nd.us from PSL
m-c: 2014-08-13

Bug 1024631 - Remove additional line breaks between 4th level .us TLD sections
m-c: 2014-08-13

Bug 1025002 - et domains are now registrable at the 2nd level
m-c: 2014-08-12

Bug 1024740 - Change one instance of "engineering" to "engineer" in the PSL
m-c: 2014-08-12

Bug 1045295 - New TLD additions for TLDs contracted with ICANN from 06/05/2014 - 07/24/2014
m-c: 2014-08-06

Gerv

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8487873 [details] [diff] [review]
Patch v.1 for mozilla-aurora

Thanks for the details Gerv. Aurora+

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8487874 [details] [diff] [review]
Patch v.1 for mozilla-beta

Beta+

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8487883 [details] [diff] [review]
Patch v.1 for mozilla-esr31

It's early in the ESR31 cycle. We should take this to avoid issues for users on that channel. ESR31+

Comment 8

[Gervase Markham [:gerv]]

Bhavana: would you take this change on b2g32 and/or b2g30?

Gerv

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8487874 [details] [diff] [review]
Patch v.1 for mozilla-beta

15 out of 23 hunks FAILED -- saving rejects to file netwerk/dns/effective_tld_names.dat.rej

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b6916340fd5d
https://hg.mozilla.org/releases/mozilla-esr31/rev/09f490633c9b

Also, commit messages on the patches would have been helpful.

Comment 11

[Gervase Markham [:gerv]]

Sorry about the commit messages; I completely forgot.

Not sure what happened to my patch for beta - sorry about that, too. I'll redo it. 

Gerv

Comment 12

[Gervase Markham [:gerv]]

Attachment: Patch v.2 for mozilla-beta

Ah, I was stuck on a stale relbranch.

Gerv

Comment 13

[Gervase Markham [:gerv]]

Attachment: Patch v.3 for mozilla-beta

...and here's one with a checkin comment :-)

Gerv

Comment 14

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8488525 [details] [diff] [review]
Patch v.3 for mozilla-beta

Let's try beta again.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5b7a15b4fee2

Comment 16

[bhavana bajaj [:bajaj]]

(In reply to Gervase Markham [:gerv] from comment #8)
> Bhavana: would you take this change on b2g32 and/or b2g30?
> 
> Gerv

Gerv, unless this is a stop-ship blocker or a chemspill level issue that we want to backport on fxos (does not look like that to ), this is likely to go in in 2.1 at the earliest

Comment 17

[Gervase Markham [:gerv]]

Bhavana: it's neither a shipstopper nor a chemspill. It is, however, a great ridealong if you do have a chemspill. It's overwriting a single data file, very low risk, no "porting" needed, and it makes a bunch of domains (including IDN domains) have better behaviour.

Gerv

Comment 18

[bhavana bajaj [:bajaj]]

ryan, can we please backort this to b2g32 with a =bajaj, given we took this for esr as well and gerv's input above?

Comment 19

[Gervase Markham [:gerv]]

ryanvm: I think comment 18 is addressed to you...

Gerv

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/9acd5febc7d1

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g32_v2_0m/rev/9acd5febc7d1