1066377 - Improve the layout of the repo menu

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Mockup

Bug 1045618 changed the repo panel into a plain dropdown menu, which is much nicer for scanning than the panel ended up being.

I think the dropdown menu could be further cleaned up by making it a two-column menu, so it takes up less vertical space.

Attached is kind of what I was thinking this could be.

On the top of the left column, we could have all of the repos from the "development" group. To the right of that, everything from "release-stabilization".

Below them, the rest of the categories can be laid out in such a way that everything fits next to the "projects" group.



This layout keeps most of the sheriffs' frequently accessed repositories at the top of the menu, while still separating the development and stabilization branches. 

On decently sized/resolutioned monitors, the entire menu's contents should be visible with minimal or no scrolling required.

Comment 1

[Jonathan French (:jfrench)]

I might have a look at this, and will assign myself if appropriate. Atm now having some issues pulling job data from dev/stage/prod.

Comment 2

[Ed Morley [:emorley]]

The mockup looks good; Ryan/Tomcat what do you think? (Compare to current treeherder-dev http://treeherder-dev.allizom.org/ )

Comment 3

[Ryan VanderMeulen [:RyanVM]]

lgtm!

Comment 4

[Jonathan French (:jfrench)]

Sorry I've been fixing a bunch of other bugs and haven't had time for this one yet. I'll un-assign myself for now. If someone else wants to take it, feel free. I will investigate it more if/when I can.

Comment 5

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:repomenu > mozilla:master

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Screenshot of PR

Below the fold is the rest of the 'taskcluster' and 'qa automation tests' group repos, and the entirety of the 'other' group.

Comment 7

[Carsten Book [:Tomcat]]

Comment on attachment 8856308 [details]
Screenshot of PR

looks nice ! 

at some point i guess for community members some tooltips at the repos would be nice but i guess that can come at a later point

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I've added tooltips to the repo group headers.

Comment 9

[Ed Morley [:emorley]]

Comment on attachment 8856307 [details] [review]
[treeherder] KWierso:repomenu > mozilla:master

Looks good!

I wonder if we should also move the comm-* repos to their own group?

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8856307 [details] [review]
[treeherder] KWierso:repomenu > mozilla:master

I've done a major rewrite of the PR. 

It's now arranged into two columns with css grid, rather than just floats.

There is a new 'comm-repositories' repo group, and all of the comm-* repos have been moved into this new group.

Descriptions of the repository groups have been added to each repo group, and the UI shows them in the menu via tooltips.

There's a new field in the repository model named 'is_try_repo' which is set to true for the try repos. I've moved the try repos out of the try repo group and into more fitting repo groups. This effectively removes the try repo group. The UI now looks for this new field rather than the try group for a number of checks.

A number of repos haven't had any pushes in over a month. I've marked a bunch of them as onhold to trim down the repo menu a bit. (Happy to undo some of these if they are in fact still active.)

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Repo menu with latest PR

Here's what the repo menu looks like with all of these changes.

Comment 12

[Ed Morley [:emorley]]

Comment on attachment 8856307 [details] [review]
[treeherder] KWierso:repomenu > mozilla:master

Have left some comments :-)

Comment 13

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/2e2fba0d2b2f4280ac98fed089e3ce43a61077d4
Bug 1066377 - Convert repo menu to a two-column grid

https://github.com/mozilla/treeherder/commit/fb7f88e0abe26cfc76d32a3231b214af3e71cf8a
Bug 1066377 - Create a comm-repositories repo group

https://github.com/mozilla/treeherder/commit/084dec8c3640adbc0eca7aef09f2e87297725e01
Bug 1066377 - Add descriptions to some repo groups

https://github.com/mozilla/treeherder/commit/a4a65ed5945d1f14f1c25569370a67c64cf851ba
Bug 1066377 - Change how try repos are identified

https://github.com/mozilla/treeherder/commit/a081b32fd8b0849744e7c65ea46a666e9f12b0a2
Bug 1066377 - Update the repo group for various repositories. Use the new way to identify try repos.

https://github.com/mozilla/treeherder/commit/2109072693e0449cff3b4e4eec3cbc75ac29d630
Bug 1066377 - Change the order used to display repo groups in the menu

https://github.com/mozilla/treeherder/commit/8061296172c80f3e4a186f3d959027f5406bbf4c
Bug 1066377 - Mark a few repos as onhold for sure