1066494 - The "Please enter the master password" string appears to be unlocalized/hard-coded

Status: RESOLVED INACTIVE

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Adrian Kalla [:adriank]]

Attachment: Screenshot_2014-09-12-10-09-39.png

Current Fennec nightly: the string "Please enter the master password (...)" ( https://hg.mozilla.org/mozilla-central/file/2db5b64f6d49/security/manager/locales/en-US/chrome/pipnss/pipnss.properties#l6 ) should appear in a Polish Fennec as https://hg.mozilla.org/l10n-central/pl/file/8974325e0487/security/manager/chrome/pipnss/pipnss.properties#l6 but it is displayed in English. As it is also displayed in German Fennec in English, I guess it will be in other locales too.

Steps to reproduce:
1. Install a multi-locale build of Fennec nightly
2. Set-up a master password
3. Switch the locale to Polish or German
4. Restart Fennec
5. Go to a site, where the master password dialog should appear
6. See the "Please enter the master password (...)" in English

Comment 1

[Axel Hecht [:Pike]]

Nice catch, that's because pipnss.properties isn't hooked up in mobile/android/locales/jar.mn.

Happy to mentor this bug :-)

Comment 2

[Curtis Rasmussen [:Crts]]

Hello, if someone could assign me to this bug that'd be great! Thanks!

Comment 3

[Curtis Rasmussen [:Crts]]

Hey Axel,

So I'm having some trouble getting the multilocale build working - I'm following the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android#Multilocale_builds, but I'm getting an error saying that: 

10:32:15    ERROR -  make: *** No rule to make target `package'.  Stop.
10:32:15    ERROR - Return code: 2

Anyways, I've been looking at the jar.mn file and the pipnss file - does the file have to move into mobile/android/locales/AB_CD/pipnss.properties?

Comment 4

[Axel Hecht [:Pike]]

Hi Curtis, sorry for the lag.

I confess, I never got mozharness to work for me, and in particular if you're doing patches, you'll want to use something more atomic.

Can you list what repositories it has set up for you by now, and how your .mozconfig looks? Did you manage to build just an en-US fennec already? That might be a good starting point.

As for what you'll need to do for this patch, you'll need to create a section like we have for dom in http://mxr.mozilla.org/mozilla-central/source/mobile/android/locales/jar.mn#92 in the same jar.mn, but for security/manager. Then the build should pick it up.

Comment 5

[Curtis Rasmussen [:Crts]]

Hey Axel, I have managed to build en-US fennec already, and it's working fine. My .mozconfig is just this: https://gist.github.com/qazwse/5fd37d61e5b6df188e52

And thanks for the advice, I'll try it out.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:nalexander, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[Nick Alexander :nalexander [he/him]]

At this point, there is no Master Password support in GeckoView and the error messaging has been mostly reworked.