1066619 - PromiseWorker should accept a Promise as a message

Status: RESOLVED FIXED

(Toolkit :: Async Tooling, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

In some cases (e.g. bug 1009799), it would be much more convenient to be able to pass the arguments to `Scheduler.post` as a Promise.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: PromiseWorker.post accepts Promise as arguments

Plus as a bonus, tests for PromiseWorker.

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: PromiseWorker.post accepts Promise as arguments, v2

Better handling of corner cases.

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8489315 [details] [diff] [review]
PromiseWorker.post accepts Promise as arguments, v2

Review of attachment 8489315 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/promiseworker/PromiseWorker.jsm
@@ +249,4 @@
>     * - {number|null} outExecutionDuration A parameter to be filled with the
>     *   duration of the off main thread execution for this call.
>     * @param {*=} closure An object holding references that should not be
>     * garbage-collected before the message treatment is complete.

Maybe specify that this can be a promise, or an array containing promises?

::: toolkit/components/promiseworker/tests/xpcshell/test_Promise.js
@@ +11,5 @@
> +// Worker must be loaded from a chrome:// uri, not a file://
> +// uri, so we first need to load it.
> +
> +let WORKER_SOURCE_URI = "chrome://promiseworker/content/worker.js";
> +do_load_manifest("data/chrome.manifest");

I'm going to assume that the relative URL here just works with the manifest declaration.

Comment 4

[David Teller [:Yoric] - still alive but not very active]

(In reply to Nathan Froyd (:froydnj) from comment #3)
> I'm going to assume that the relative URL here just works with the manifest
> declaration.

Yes, it does.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Attachment: PromiseWorker.post accepts Promise as arguments, v3

Trivial changes.
Try: https://tbpl.mozilla.org/?tree=Try&rev=fe83724433a6

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/422d828c179e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/422d828c179e