106674 - Folderpane: Bold text and icons are gone

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P1)

Description

[Quinn Yost (mythdraug)]

Account names are no longer bold

Folders with new mail are not longer bold



Build: 2001102503  Win32

Comment 1

[scottputterman]

adding the fact that folder icons are gone.  Confirming.  My guess is that this
is related to everything that's making the product crash.

Comment 2

[Håkan Waara]

I love the trunk.

Comment 3

[Asa Dotzler [:asa]]

*** Bug 106753 has been marked as a duplicate of this bug. ***

Comment 4

[Francisco León]

Man, did the Windows XP launch screw mozilla up <g>
Marking ALL
There are so many regressions today

Comment 5

[(not reading, please use [e-mail] instead)]

accepting, I'll investigate.

Comment 6

[Ben Ruppel]

It's like the mozilla apocalypse.  After this long period of stability, these
last two days will live on in infamy!

Comment 7

[(not reading, please use [e-mail] instead)]

it doesn't look like we're even loading the folderPane.css stylesheet.

(that's why there isn't any bold or icons.)

if I append the contents of folderPane.css into outliner.css, it works.

investigating, this might be boris's changes.

Comment 8

[(not reading, please use [e-mail] instead)]

boris, this goes away if I revert your checkin.

Comment 9

[(not reading, please use [e-mail] instead)]

here's what I backed out locally:

cvs update -j1.135 -j1.134 mozilla/content/xml/document/src/nsXMLDocument.cpp
cvs update -j1.37 -j1.36 mozilla/content/xml/content/src/nsXMLProcessingInstruct
ion.cpp
cvs update -j3.94 -j3.93 mozilla/content/html/style/src/nsCSSLoader.cpp
cvs update -j3.14 -j3.13 mozilla/content/html/style/public/nsICSSLoader.h
cvs update -j1.5 -j1.4 mozilla/content/base/src/nsStyleLinkElement.h
cvs update -j1.12 -j1.11 mozilla/content/base/src/nsStyleLinkElement.cpp
cvs update -j3.7 -j3.6 mozilla/content/base/public/nsIStyleSheetLinkingElement.h

Comment 10

[(not reading, please use [e-mail] instead)]

this is the minimal back out:

cvs update -j3.94 -j3.93 mozilla/content/html/style/src/nsCSSLoader.cpp
cvs update -j3.14 -j3.13 mozilla/content/html/style/public/nsICSSLoader.h

Comment 11

[(not reading, please use [e-mail] instead)]

Attachment: temporary fix, sorry hwaara

Comment 12

[(not reading, please use [e-mail] instead)]

this is a great bug.

the special character in hwaara's name causes us to fail to convert the style 
sheet to UTF-8.

this is exposed by a recent check in by boris.

I'll open a new bug on boris, so he can fix the real problem (he's still 
thinking about it) and then he can restore hwaara's name.

sorry about that hwaara.

Comment 13

[Boris Zbarsky [:bzbarsky]]

Um... correction.  :)  Convert _from_ UTF-8.

Basically, my change had one major impact on chrome sheets.  Instead of assuming
that the default encoding is ISO-8859-1, we now use the document encoding which
defaults to UTF-8 for XML documents using one-byte chars (ie all of our XUL). 
That stylesheet cannot be converted from UTF-8 to Unicode because of the å in
Håkan's name -- that char followed by "k" is apparently not a valid char
sequence in UTF-8, while it is in ISO-8859-1.

Further discussion in the new bug.

Comment 14

[(not reading, please use [e-mail] instead)]

this is fixed, I changed the character in the file.

http://bugzilla.mozilla.org/show_bug.cgi?id=106843

tracks the real issue, once resolved, we'll add the character back.

Comment 15

[laurel]

*** Bug 106871 has been marked as a duplicate of this bug. ***

Comment 16

[laurel]

*** Bug 106828 has been marked as a duplicate of this bug. ***

Comment 17

[Quinn Yost (mythdraug)]

vrfy on 2001102603 win32

Comment 18

[laurel]

Thanks for verifying this, but we usually don't mark verified until it's been
checked on all platforms.