1066988 - unittest picker_test.js using assert.include for testing object, not Array or string

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[sv99]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20140913030206

Steps to reproduce:

 test('shape:prototype ', function() {
    assert.ok(Picker);
    assert.include(Picker.prototype, 'reset');
    assert.include(Picker.prototype, 'value');

Picker.prototype - object not Array and not string.
chai used in test-agent simple do nothing in this case.

Write any value and test !!OK!!
assert.include(Picker.prototype, 'reset_reset');

Comment 1

[sv99]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24023

Comment 2

[sv99]

Attachment: Link to PR (rebased)

Comment 3

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8498745 [details] [review]
Link to PR (rebased)

The linter tests fail on your PR, saying "expect" is not defined.

Comment 4

[sv99]

replace expect to assert

Comment 5

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8498745 [details] [review]
Link to PR (rebased)

thanks!

Comment 6

[Carsten Book [:Tomcat]]

master: https://github.com/mozilla-b2g/gaia/commit/75915628611e946522fe21587fe9eef76793e36c

Comment 7

[Kevin Grandon :kgrandon]

This was backed out for not having a bug number in the commit. Commits which do not have bug numbers listed can cause a lot of headache down the road, so please ensure that commits always list the bug number. This is both the job of the author and reviewer to enforce.

I've gone ahead and re-landed this with the proper commit message, containing the bug number.

Backed out in: https://github.com/mozilla-b2g/gaia/commit/d1a29dc02e79dd1cfcd5847b5e8da9c7d65bebd9
Re-landed with the proper commit message: https://github.com/mozilla-b2g/gaia/commit/eb23ec537d5ec9459320a886dd893aca467711c3