Closed
Bug 106748
Opened 23 years ago
Closed 22 years ago
When adding custom component, the description and size may be left blank
Categories
(CCK Graveyard :: CCK-Wizard, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: BarrettLndstrm, Assigned: shrutiv)
Details
Attachments
(4 files, 1 obsolete file)
8.43 KB,
patch
|
Details | Diff | Splinter Review | |
149.88 KB,
image/jpeg
|
Details | |
6.19 KB,
patch
|
Details | Diff | Splinter Review | |
1.81 KB,
patch
|
Details | Diff | Splinter Review |
I don't consider this a blocker by any means, but it's something to look at for the future. Currently, if you add a custom component, but do not add the description or the size, the component is added anyways, and the installer builds with no problems. But the reported disk space needed by the installer is incorrect (offset by the actual size of the custom component). I think there should be some sort of catch that forces users to add the name and size if one has not been given for the component.
Assignee | ||
Comment 2•23 years ago
|
||
Display error message if the user adds a custom component, but does not add the description or the size.
Status: NEW → ASSIGNED
Priority: -- → P2
Assignee | ||
Updated•23 years ago
|
Priority: P2 → P1
Assignee | ||
Comment 3•22 years ago
|
||
In addition to displaying the error message, this patch also includes some screen refinement.
Assignee | ||
Comment 4•22 years ago
|
||
Assignee | ||
Comment 5•22 years ago
|
||
Assignee | ||
Updated•22 years ago
|
Whiteboard: need r=
Comment 6•22 years ago
|
||
I think you could be a little more descriptive in the code describing what IsFieldEmpty() does. Seems that the other parameters listed are only checked if the first parameter has a value. Is that right? This line in cckwiz/iniFiles/build_page1.ini looks suspect because IsFieldEmpty is in there twice: +onNext=IsFieldEmpty(%CustomComponentPath1%,%CustomComponentDesc1%,% CustomComponentSize1%,Enter the description and size for the additional component);IsFieldEmpty(%CustomComponentPath2%,%CustomComponentDesc2%,% CustomComponentSize2%,Enter the description and size for the additional component);Message(Are you ready to build your customized installer?);RunIB ();Msg(Installer creation is complete. The build is in %Root%Configs\% CustomizationList%\Output) This line in Factory's build_page1.ini looks suspect for the same reason as above and because the functions are in a different order than CCK's: +onNext=Message(Are you ready to build your customized installer?);IsFieldEmpty (%CustomComponentPath1%,%CustomComponentDesc1%,%CustomComponentSize1%,Enter the description and size for the additional component);IsFieldEmpty(% CustomComponentPath2%,%CustomComponentDesc2%,%CustomComponentSize2%,Enter the description and size for the additional component);RunIB();Msg(Installer creation is complete. The build is in %Root%Configs\%CustomizationList%\Output) And I think you missed MyEnterprise/deploykit.che in Factory.
Assignee | ||
Comment 7•22 years ago
|
||
>I think you could be a little more descriptive in the code describing what >IsFieldEmpty() does. I'll add a few more comments >Seems that the other parameters listed are only checked if >the first parameter has a value. Is that right? Yes. >This line in cckwiz/iniFiles/build_page1.ini looks suspect because IsFieldEmpty >is in there twice There are 2 additional components. So, I'm performing the check twice... once for each component. >This line in Factory's build_page1.ini looks suspect for the same reason as >above and because the functions are in a different order than CCK's: good catch. I have accidentally put the functions in wrong order for factory and I have missed MyEnterprise/deploykit.che.
Assignee | ||
Comment 8•22 years ago
|
||
Attachment #81596 -
Attachment is obsolete: true
Assignee | ||
Comment 9•22 years ago
|
||
Assignee | ||
Comment 11•22 years ago
|
||
Marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•