1067482 - Add treeherder support for Android instrumentation tests

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Nick Alexander :nalexander [he/him]]

My jobs appear to be running (\o/) and are currently listed as "U".  I'd like to get names on treeherder whenever is convenient.

The bug for TBPL is Bug 1067480, which is the Android instrumentation analog to Bug 974358.  This bug is sort of an analog of Bug 1060763, except that ticket is not web-platform-tests only.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Link to pull request 221

I think this is what's needed to add the two tests into a single group, but I haven't managed to have my changes show up on my vagrant instance.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Wes Kocher (:KWierso) from comment #1)
> Created attachment 8489631 [details] [review]
> Link to pull request 221
> 
> I think this is what's needed to add the two tests into a single group, but
> I haven't managed to have my changes show up on my vagrant instance.

If this isn't enough, could we get documentation somewhere on what exactly is involved in adding new tests or groups of tests?

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8489631 [details] [review]
Link to pull request 221

Let's hold off this until the names in bug 1067480 are finalised.

Also, the PR is missing the grouping change (I'll comment in the PR).

Comment 4

[Ed Morley [:emorley]]

The TBPL change is now deployed - Wes I don't suppose you could make the tweaks to the PR so we can get this landed? (Unlike TBPL, mis-categorised previously ingested jobs aren't automatically fixed once a change is made, so the less time the ingestion is incorrect, the better). Or I'm happy to make them if you'd prefer? :-)

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Done. Care to take another look?

Comment 6

[Ed Morley [:emorley]]

Could you rebase it on top of the recent changes? :-)

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Done.

Comment 8

[Ed Morley [:emorley]]

Comment on attachment 8489631 [details] [review]
Link to pull request 221

Have left a comment on the PR :-)

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8489631 [details] [review]
Link to pull request 221

I believe I've addressed that comment, and the tests are passing.

Comment 10

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/68acafed7ecdd853efcd86621361a8d7acacc3b3
Bug 1067482 - Add support for Android Instrumentation tests

https://github.com/mozilla/treeherder-service/commit/f561d5fc968895a90d7f4872cd439d7cacace1e4
Merge pull request #221 from KWierso/1067482

Bug 1067482 - Add support for Android instrumentation tests

Comment 11

[Ed Morley [:emorley]]

Thanks! :-)