Closed
Bug 1067597
Opened 10 years ago
Closed 10 years ago
python errors in mobile_l10n.py
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jlund, Assigned: kmoir)
Details
Attachments
(1 file)
|
2.88 KB,
patch
|
jlund
:
review+
kmoir
:
checked-in+
|
Details | Diff | Splinter Review |
This was discovered by running './unit.sh': ### Running pyflakes scripts/mobile_l10n.py:40: 'VCSMixin' imported but unused scripts/mobile_l10n.py:41: 'BaseScript' imported but unused scripts/mobile_l10n.py:276: local variable 'abs_work_dir' is assigned to but never used scripts/mobile_l10n.py:556: local variable 'c' is assigned to but never used scripts/mobile_l10n.py:566: undefined name 'fatal' the last one would cause a python error (it's missing self). I think it would only be reached from a negative result so we probably haven't seen it get hit yet.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → kmoir
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8489741 -
Flags: review?(jlund)
|
Reporter | |
Comment 2•10 years ago
|
||
Comment on attachment 8489741 [details] [diff] [review] bug1067597.patch Review of attachment 8489741 [details] [diff] [review]: ----------------------------------------------------------------- lgtm :)
Attachment #8489741 -
Flags: review?(jlund) → review+
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8489741 -
Flags: checked-in+
|
||
Comment 3•10 years ago
|
||
Merged to prod (2014-09-16 08:21 PT)
|
|
Assignee | |
Comment 4•10 years ago
|
||
Should have closed this a while ago
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•