Closed
Bug 1067602
Opened 10 years ago
Closed 10 years ago
The first time you type in URLbar, you get "JavaScript strict warning: file:///$OBJDIR/dist/bin/components/UnifiedComplete.js, line 760: ReferenceError: reference to undefined property match.finalCompleteValue"
Categories
(Toolkit :: Places, defect)
Tracking
()
People
(Reporter: dholbert, Assigned: mak)
References
Details
Attachments
(1 file)
1.08 KB,
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
STR: 1. Start a m-c debug build from the terminal, with a fresh profile (empty folder). 2. Ctrl+L to focus URLbar. Type the character "a" 3. After the autocomplete dropdown appears, look at your terminal. ACTUAL RESULTS: { JavaScript strict warning: file:///$OBJDIR/dist/bin/components/UnifiedComplete.js, line 760: ReferenceError: reference to undefined property match.finalCompleteValue } Setting as blocking bug 995091, since this is at least tied to that feature. (though there may be a better bug for this to block or depend on; feel free to adjust)
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(mak77)
Reporter | ||
Comment 1•10 years ago
|
||
I'm not sure if I should trust the line number, but if I should, then line 760 from that file (loaded using the URL from my terminal) refers to the last line of code here (I'm providing a bit of pruned before-code for context): > _matchSearchEngineUrl: function* () { [...] > let match = yield PlacesSearchAutocompleteProvider.findMatchByToken( > this._searchString); [...] > // In any case, we should never arrive here with a value that doesn't > // match the search string. If this happens there is some case we > // are not handling properly yet. > if (!value.startsWith(this._originalSearchString)) { > Components.utils.reportError(`Trying to inline complete in-the-middle > ${this._originalSearchString} to ${value}`); (Line 760 is this final line here: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ That line was added recently in bug 1059846.
Blocks: 1059846
Assignee | ||
Comment 2•10 years ago
|
||
this is a very strange error, match.finalCompleteValue can be undefined but we are just passing it out... and I can't see how stuff at line 760 is involved, it should even be executed. I guess it's easier to try and see what I figure out.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Flags: needinfo?(mak77)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8497110 -
Flags: review?(bmcbride)
Assignee | ||
Updated•10 years ago
|
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+
Updated•10 years ago
|
Attachment #8497110 -
Flags: review?(bmcbride) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/af3a8b7f7cb2
Target Milestone: --- → mozilla35
Updated•10 years ago
|
Iteration: --- → 35.3
https://hg.mozilla.org/mozilla-central/rev/af3a8b7f7cb2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•