1068199 - Disable e10s when hardware acceleration is disabled

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Chris Peterson [:cpeterson]]

e10s is unhappy when hardware acceleration is disabled, e.g. bug 1026521 and bug 1026093. As a temporary workaround, we should add hardware acceleration to our list of conditions that can disable e10s during startup.

Comment 1

[Jim Mathies [:jimm]]

This is tricky, since we don't just check a pref for acceleration, we make a lot of last minute decisions in the widget code where we set up composition about turning acceleration on.

http://mxr.mozilla.org/mozilla-central/source/widget/xpwidgets/nsBaseWidget.cpp#771
http://mxr.mozilla.org/mozilla-central/source/widget/windows/nsWindow.cpp#3295

Comment 2

[Jim Mathies [:jimm]]

Attachment: part 1 - win support

Bas, would you mind looking this over? I think I have all the checks I need based on a lot of poking around in widget/gfx code.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I got the sense that this was also (or primarily?) a Mac problem.

Comment 4

[Bas Schouten (:bas.schouten)]

Comment on attachment 8490769 [details] [diff] [review]
part 1 - win support

Review of attachment 8490769 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine, I wonder if there isn't an easier way to detect this, but probably not as early on as this.

Comment 5

[Jim Mathies [:jimm]]

(In reply to Bas Schouten (:bas.schouten) from comment #4)
> Comment on attachment 8490769 [details] [diff] [review]
> patch v.1
> 
> Review of attachment 8490769 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This looks fine, I wonder if there isn't an easier way to detect this, but
> probably not as early on as this.

Yeah nothing is initialized this early, I was hoping something like gfxPlatform would be but no luck.

(In reply to Bill McCloskey (:billm) from comment #3)
> I got the sense that this was also (or primarily?) a Mac problem.

Ah, thought mac and linux were ok. Working on a mac patch currently on top of this.

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to Jim Mathies [:jimm] from comment #5)
> (In reply to Bill McCloskey (:billm) from comment #3)
> > I got the sense that this was also (or primarily?) a Mac problem.
> 
> Ah, thought mac and linux were ok. Working on a mac patch currently on top
> of this.

Mac is affected. See bug 1026093.

Comment 7

[Jim Mathies [:jimm]]

Attachment: part 2 - add macos support

Comment 8

[Jim Mathies [:jimm]]

Attachment: part 1 - win support

- merged to mc tip

Comment 9

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8490838 [details] [diff] [review]
part 2 - add macos support

Review of attachment 8490838 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/xre/nsAppRunner.cpp
@@ +4568,5 @@
> +    SInt32 bugfix = nsCocoaFeatures::OSXVersionBugFix();
> +    if (major == 10 && minor == 6 && bugfix <= 2) {
> +      accelDisabled = true;
> +    }
> +#endif

This should be moved into a common helper so we don't accidentally have these two checks diverge.

Comment 10

[Jim Mathies [:jimm]]

Attachment: macos support

Comment 11

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8491058 [details] [diff] [review]
macos support

Review of attachment 8491058 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/xre/nsAppRunner.cpp
@@ +4561,5 @@
>        }
>      }
> +
> +#if defined(XP_MACOSX)
> +    // See nsBaseWidget::ComputeShouldAccelerate

This comment can go.

Comment 12

[Jim Mathies [:jimm]]

Attachment: part 2 - macos support

I moved it into nsCocoaFeatures.

Comment 13

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8491064 [details] [diff] [review]
part 2 - macos support

Review of attachment 8491064 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/xre/nsAppRunner.cpp
@@ +4561,5 @@
>        }
>      }
> +
> +#if defined(XP_MACOSX)
> +    // See nsBaseWidget::ComputeShouldAccelerate

This comment can go.

Comment 14

[Jim Mathies [:jimm]]

try push:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=0518fb074e66

Comment 15

[Jim Mathies [:jimm]]

Attachment: rollup

Comment 16

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/04458f023e47

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/04458f023e47