Closed
Bug 1068417
Opened 10 years ago
Closed 10 years ago
Fix -Wunused-const-variable warnings in widget/cocoa
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
| Tracking | Status | |
|---|---|---|
| firefox32 | --- | unaffected |
| firefox33 | --- | affected |
| firefox34 | --- | wontfix |
| firefox35 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
4.43 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
Bug 899334 removed the reference to kIconBytes: widget/cocoa/nsMenuItemIconX.mm:54:23 [-Wunused-const-variable] unused variable 'kIconBytes' And the following constants are no longer necessary because they are only used to define (removed) kIconBytes: kIconBitsPerComponent kIconComponents kIconBitsPerPixel kIconBytesPerRow kIconBytes
Attachment #8490470 -
Flags: review?(mstange)
|
Assignee | |
Comment 1•10 years ago
|
||
I forgot to mention that this patch also removes some trailing whitespace in the same source file (nsMenuItemIconX.mm).
|
||
Updated•10 years ago
|
Attachment #8490470 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d53de50d5a6
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3d53de50d5a6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
|
||
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•