1068455 - MP4/h264 playback is broken in 10.7

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

The AppleVTLinker assumes the VideoToolbox framework is located in /System/Library/Frameworks

However, in 10.7, the VideoToolbox framework is located in /System/Library/PrivateFrameworks as this framework is only officially available in 10.8

Comment 1

[Jean-Yves Avenard [:jya]]

Make it depend on 1062654, as I'm not going to rebase those patches for a nth time !

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Enable VideoToolbox framework in 10.7

Enable VideoToolbox framework in 10.7

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8490609 [details] [diff] [review]
Enable VideoToolbox framework in 10.7

Review of attachment 8490609 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this!

Comment 4

[Jean-Yves Avenard [:jya]]

https://tbpl.mozilla.org/?tree=Try&rev=d2035568819e

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e39589387cc3

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e39589387cc3

Comment 7

[Jean-Yves Avenard [:jya]]

Comment on attachment 8490609 [details] [diff] [review]
Enable VideoToolbox framework in 10.7

Approval Request Comment
[Feature/regressing bug #]: 8490609
[User impact if declined]: mp4 video playback isn't possible in 10.7 without it
[Describe test coverage new/current, TBPL]: Currently tested and passing all tests in 10.8
[Risks and why]: little, it really is just fixing an oversight.
[String/UUID change made/needed]:

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to Jean-Yves Avenard [:jya] from comment #7)
> Approval Request Comment
> [Feature/regressing bug #]: 8490609
We're not yet in the 8 million range for bug numbers. ;) Can you please provide the correct bug number so that we can determine when this issue was introduced?

Comment 9

[Ralph Giles (:rillian)]

The original feature was bug 941296. That's as reasonable a referent as any.

Comment 10

[Jean-Yves Avenard [:jya]]

It turns out that the VT code in current Aurora won't work on 10.7. For VT to work in 10.7 (and 10.6) it requires 1059066 (re-based version).

The core reason for VT not to work is that the VT decoder wasn't provided the format type to output.

Comment 11

[Lawrence Mandel [:lmandel] (use needinfo)]

Does comment 10 mean that there is no point taking this change on Aurora unless we also take bug 1059066? If so, is there a good reason to push for this in 34 or can we take this in 35?

Comment 12

[Ralph Giles (:rillian)]

I was surprised by comment 10 as well, and would like to hear details. I do think it's reasonable to wait for 35 for this change. Older Macs are more likely to have flash which most sites still use as a fallback.

Comment 13

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

(In reply to Lawrence Mandel [:lmandel] from comment #11)
> Does comment 10 mean that there is no point taking this change on Aurora
> unless we also take bug 1059066? If so, is there a good reason to push for
> this in 34 or can we take this in 35?

The reason for uplifting this into 34 is that it gives us across the board support on Mac OSX rather than having 10.6 and 10.7 unsupported and only 10.8 supported. AAC on Mac OSX is specifically important to the games initiative.

Comment 14

[Lawrence Mandel [:lmandel] (use needinfo)]

Is bug 1059066 required as well?

Comment 15

[Ralph Giles (:rillian)]

I believe we can do this without the patch from bug 1059066. I've asked jya to produce a minimal, combined, aurora-specific patch, and we'll request for approval on that.

Comment 16

[Ralph Giles (:rillian)]

Backport of this with other required changes in is bug 1070703. Please follow-up there for Aurora (Firefox 34) support.