1068505 - React to the removal of non-Encoding Standard Mac encoders

Status: RESOLVED FIXED

(MailNews Core :: Internationalization, defect)

Description

[Henri Sivonen (:hsivonen)]

Bug 997133 removed encoders for Mac encodings other than MacRoman and MacCyrillic. The decoders for the encodings whose encoders were removed are used by gfx for decoding the names of legacy fonts. The encodings aren't exposed to the Web.

comm-central should either
 1) Remove these encodings form charsetalias.properties and the like. (Preferred.)
OR
 2) Import the removed encodings into comm-central.

Comment 1

[Henri Sivonen (:hsivonen)]

https://groups.google.com/forum/#!topic/mozilla.dev.apps.thunderbird/2P5kCJJS_WI

Comment 2

[Henri Sivonen (:hsivonen)]

(In reply to Henri Sivonen (:hsivonen) from comment #0)
>  1) Remove these encodings form charsetalias.properties and the like.

Oops. Keeping the aliases but marking these as notForOutgoing makes more sense.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: bug1068505_react_removed_x-mac_encodings.patch

I see no reason to import the encoders.

Comment 4

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8526099 [details] [diff] [review]
bug1068505_react_removed_x-mac_encodings.patch

Review of attachment 8526099 [details] [diff] [review]:
-----------------------------------------------------------------

So, I had a looksie. We don't use .notForOutgoing anywhere anymore--it used to be use in nsCharsetMenu, but bug 999881 replaced that use with CharsetMenu.jsm instead (since nsCharsetMenu died). As a result, the encoders that we support are hardcoded in that file, and as a few other lists in a few other files.

In short, this patch does nothing useful.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: bug1068505_react_removed_x-mac_encodings.patch

Since the mac decoders are still in place, I think there's not much to do, except to clean up the remaining unused notForOutgoing, notForBrowser and an outdated XXX comment.

Comment 6

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/ce58d0c3e55d -> FIXED