Closed Bug 1068983 Opened 10 years ago Closed 9 years ago

Photo view: Adjacent photos should be hidden from screen reader

Categories

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Gallery
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S4 (23jan)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

(Keywords: access, Whiteboard: [b2ga11y p=1])

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27127
46 bytes, text/x-github-pull-request
pdahiya
: review+
Bebe
: review+
bajaj
: approval-gaia-v2.2+
Details | Review 
They are currently scrolled into view by navigating. This messes up the state of the photo viewer.
Assignee: nobody → eitan
Comment on attachment 8544159 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27127

This is a pretty simple patch. I added zac as a reviewer for the ui testing bits.
Attachment #8544159 - Flags: review?(zach)
Attachment #8544159 - Flags: review?(pdahiya)
Comment on attachment 8544159 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27127

r+ for the changes other than python tests. I am not familiar with python tests and will have Zac review testing part of the patch. Thanks!
Attachment #8544159 - Flags: review?(pdahiya) → review+
Comment on attachment 8544159 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27127

Bebe,

Could you please review the test?
Attachment #8544159 - Flags: review?(zach) → review?(florin.strugariu)
Comment on attachment 8544159 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27127

Pull looks OK to me...

I still have a question about the `debug` tag

retriggered the build a few times to check for intermittent fails
Looks green now.

I copied the skip condition from here, because it is a very similar test:
https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/manifest.ini#L19
Attachment #8544159 - Flags: review?(florin.strugariu) → review+
https://github.com/mozilla-b2g/gaia/commit/e91cdb71d55e29bf41cca768591db64785d63801
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8544159 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27127

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Adjacent frames of photos/videos will be "visible" to the screen reader user.
[Testing completed]: Manual and Gip test added.
[Risk to taking this patch] (and alternatives if risky): Low, changes are to aria-hidden which has no affect on layout.
[String changes made]: None.
Attachment #8544159 - Flags: approval-gaia-v2.2?
Attachment #8544159 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: