Closed
Bug 1069188
Opened 10 years ago
Closed 10 years ago
[NFC] NfcManager should not expose sessionToken to regular webapps
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(b2g-v2.2 fixed)
RESOLVED
FIXED
2.1 S5 (26sep)
| Tracking | Status | |
|---|---|---|
| b2g-v2.2 | --- | fixed |
People
(Reporter: tauzen, Assigned: tauzen)
References
Details
Attachments
(1 file)
NfcManager fires mostly NDEF related activities which can be handled by regular web apps. Since Bug 1046554 landed, sessionToken is not needed to obtain NFCPeer/NFCTag by regular web apps. Bug 1054139 will require "nfc-manager" permissions to use getNFCPeer/getNFCTag, so essentially sessionToken will not mean anything for web apps and should not be passed to the activity.
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8492936 -
Flags: review?(gweng)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8492936 [details] [review] pull-request-1069188.txt Two nits. Please fix them and land it, thanks.
Attachment #8492936 -
Flags: review?(gweng) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Thanks for the review! I fixed the nits and try is green once again.
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•10 years ago
|
||
Correction, Gij failed on unrelated test.
|
||
Comment 5•10 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/38a993ba95a5829bc7926e9424bb3a8a7b14a0f2
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.2:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S5 (26sep)
You need to log in
before you can comment on or make changes to this bug.
Description
•