1069484 - Usage: Main screen: Usage type and amount should be unified.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Right now it is possible to navigate separately to the text representing the usage type and the text representing the amount. A good solution is to unify those to things into 1 item so the screen reader user hears both the usage type and amount at once.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25852

I tweaked the gaia-checkbox styling as well to make it easier to drop in place of BB checkboxes.

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8517619 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25852

I think that the main usage of the gaia-checkboxes were geared towards the settings app. I think by doing these changes it might make it harder to get into places like the settings app?

Seems fine for now, but we might have to revisit this in the future. Thanks for the patch!

Comment 4

[Salvador de la Puente González [:salva]]

Comment on attachment 8517619 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25852

The patch looks great but I would someone from the Web Components team to review the patch as it is including changes outside the Cost Control application.

Comment 5

[Salvador de la Puente González [:salva]]

Kevin, was you who write the check-box part?

Comment 6

[Kevin Grandon :kgrandon]

(In reply to Salvador de la Puente González [:salva] from comment #5)
> Kevin, was you who write the check-box part?

Yes, I believe my review should be fine for this part of the PR.

Comment 7

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/5ae28ff11b982e2bd7d1aa097cda131536952bdc