1069569 - Complain about missing tests even when the test manifest is not filtered at build time

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

The sandbox currently doesn't complain if a test file is missing unless the test manifest is filtered at build time.  That applies to all suites but xpcshell tests at this time.

This is like Bug 979640, but for xpcshell tests.  (And any new suites that define manifests but don't filter at build time.)

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Complain about missing test files for all suites. r=mshal

We had some tests that aren't well formed with the new condition.
Everything else is clear, I think.  Try build forthcoming.

Comment 2

[Nick Alexander :nalexander [he/him]]

https://tbpl.mozilla.org/?tree=Try&rev=def9af587983

Comment 3

[Andrew Halberstadt [:ahal]]

Since bug 857966 landed, if you filter tests with strict=True (which it looks like emitter.py is), then manifestparser should complain for you. Is that not working?

Comment 4

[Andrew Halberstadt [:ahal]]

(In reply to Nick Alexander :nalexander from comment #0)
> unless the test manifest is filtered at build time

Oh sorry, missed that part. Carry on.

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: Complain about missing test files for all suites. r=mshal

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8491755 [details] [diff] [review]
Complain about missing test files for all suites. r=mshal

Gah, bad bzexport.

Comment 7

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/a5e8a4bff194

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a5e8a4bff194