Closed Bug 1069624 Opened 10 years ago Closed 9 years ago

Make sure shuffle is a toggle button.

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Music
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S7 (6mar)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: yzen, Assigned: eeejay)

References

Details

(Keywords: access, Whiteboard: [b2ga11y p=1])

Attachments

(2 files)

[PullReq] eeejay:bug-1069624 to mozilla-b2g:master
46 bytes, text/x-github-pull-request
dkuo
: review+
Details | Review
[gaia] eeejay:bug-1069624_v2.2 > mozilla-b2g:v2.2
46 bytes, text/x-github-pull-request
bajaj
: approval-gaia-v2.2+
Details | Review 
Shuffle button should have toggle button semantics so the screen reader user knows what state it is on.
Attachment #8562366 - Flags: review?(dkuo)
Assignee: nobody → eitan
Comment on attachment 8562366 [details] [review]
[PullReq] eeejay:bug-1069624 to mozilla-b2g:master

Looks good to me and apologize for keeping you waiting!
Attachment #8562366 - Flags: review?(dkuo) → review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8578792 [details] [review]
[gaia] eeejay:bug-1069624_v2.2 > mozilla-b2g:v2.2

Rebased on v2.2

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Toggle mode of shuffle button will not be known to screen reader users
[Testing completed]: yes.
[Risk to taking this patch] (and alternatives if risky): Low.
[String changes made]: No.
Attachment #8578792 - Flags: approval-gaia-v2.2?
Attachment #8578792 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: