1069918 - Enforce required fields during contact validation in LoopContacts.jsm

Status: RESOLVED DUPLICATE of bug 1099950

(Hello (Loop) :: Client, defect, P2)

Description

[Mike de Boer [:mikedeboer]]

We'll need to enforce fields to be required that are absolutely necessary for the Loop client to function properly.
At the moment, according to the MVP UX spec, the fields required would be 'name' and 'email'. Please don't take this as a reference as the requirement(s) might chance once this bug gets implemented.

Comment 1

[Maire Reavy [:mreavy]]

Mike -- Has this already been handled in other bugs?

Comment 2

[Mike de Boer [:mikedeboer]]

Nope.

Comment 3

[:shell escalante]

validate that name, email have valid input, also phone number once that bug is input to make sure we are sending proper info to server.

Comment 4

[:shell escalante]

Hi Paolo, can you take this bug?  looking during planning meeting to find owners for P1's for this sprint.  there are several other bugs available as well - but just asking for this one.  Mike is on PTO for a couple of days (injured his hand = 12 stitches), but Jared is available if questions on area.

Comment 5

[:Paolo Amadini]

Hi Shell, from the bug description it's not clear to me why we need to do this in LoopContacts.jsm at the API level at this stage of the project, and what the interaction would be with various callers or synchronization. Can we rephrase this in terms of what we expect in terms of UX? Isn't the current behavior the correct one already, without any action required here?

Comment 6

[Maire Reavy [:mreavy]]

We want to make sure that the contact info added is formatted correctly (such that the system can use it) before the contact info saved and the user leaves the contact entry dialog. If the user has made a typo that we can flag to him/her before the entry is saved, that is a win for the user.

Mike -- am I describing the issue we're trying to fix/improve correctly?

I did just checked in Nightly, and the system will not let me save an entry unless the email address is formatted as "foo@bar" so there is some validation being done.  Perhaps that is enough, and this can wait until Fx37?

Comment 7

[Mike de Boer [:mikedeboer]]

It can wait. This bug is about enforcing data consistency, regardless of input method, so that no incomplete objects may ever be stored in the database.

Comment 8

[Maire Reavy [:mreavy]]

Thanks for clarifying, Mike.  

Let's triage this as part of Fx37.

Comment 9

[:shell escalante]

Hi Sevaan, we don't have a UX for how to handle needing name and email OR phone number.  and we need to validate email and phone to make sure they are formatted well.  there was a red box discussion with JAWS about how to handle the red box for mandatory when it's either/or

just added darrin in case this was already done in another bug.

Comment 10

[Sevaan Franks [:sevaan]]

I believe this work has been done in Bug 1099950.

Comment 11

[:shell escalante]

duping to bug 1099950 as that has the UX and one other fix request