Closed Bug 1070250 Opened 10 years ago Closed 9 years ago

Intermittent browser_toolbox_options_disable_cache.js | This test exceeded the timeout threshold.

Categories

(DevTools :: Framework, defect)

Product:
DevTools
Component:
Framework
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox35 wontfix, firefox36 wontfix, firefox37 fixed, firefox-esr31 unaffected)

Status:
RESOLVED FIXED
Milestone:
Firefox 37
Tracking Flags:
Tracking Status
firefox35 --- wontfix
firefox36 --- wontfix
firefox37 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: KWierso, Assigned: sjakthol)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

split-toolbox-options-disable-cache.patch
13.91 KB, patch
miker
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=48494355&tree=Fx-Team
Ubuntu VM 12.04 fx-team debug test mochitest-devtools-chrome-1 on 2014-09-19 12:58:10 PDT for push d94e895df009

slave: tst-linux32-spot-661



13:55:19     INFO -  721 INFO Reloaded tab Tab 3
13:55:19     INFO -  722 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_options_disable_cache.js | Tab 3 cache is enabled
13:55:19     INFO -  723 INFO Removing tab Tab 0
13:55:19     INFO -  724 INFO Removed tab Tab 0
13:55:19     INFO -  725 INFO Waiting for toolbox-destroyed
13:55:19     INFO -  726 INFO Console message: [JavaScript Error: "Handler function TabActor.prototype.onReload's delayed body threw an exception: TypeError: this.docShell is null
13:55:19     INFO -  Stack: TabActor.prototype.webNavigation@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:672:5
13:55:19     INFO -  TabActor.prototype.onReload/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:1095:7
13:55:19     INFO -  makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14
13:55:19     INFO -  Line: 672, column: 4" {file: "resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js" line: 59}]
13:55:19     INFO -  727 INFO Removing tab Tab 1
13:55:19     INFO -  728 INFO Removed tab Tab 1
13:55:19     INFO -  729 INFO Waiting for toolbox-destroyed
13:55:19     INFO -  730 INFO Console message: [JavaScript Error: "Handler function TabActor.prototype.onReload's delayed body threw an exception: TypeError: this.docShell is null
13:55:19     INFO -  Stack: TabActor.prototype.webNavigation@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:672:5
13:55:19     INFO -  TabActor.prototype.onReload/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:1095:7
13:55:19     INFO -  makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14
13:55:19     INFO -  Line: 672, column: 4" {file: "resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js" line: 59}]
13:55:19     INFO -  731 INFO Removing tab Tab 2
13:55:19     INFO -  732 INFO Removed tab Tab 2
13:55:19     INFO -  733 INFO Waiting for toolbox-destroyed
13:55:19     INFO -  734 INFO Console message: [JavaScript Error: "Handler function TabActor.prototype.onReload's delayed body threw an exception: TypeError: this.docShell is null
13:55:19     INFO -  Stack: TabActor.prototype.webNavigation@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:672:5
13:55:19     INFO -  TabActor.prototype.onReload/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:1095:7
13:55:19     INFO -  makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14
13:55:19     INFO -  Line: 672, column: 4" {file: "resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js" line: 59}]
13:55:19     INFO -  735 INFO Removing tab Tab 3
13:55:19     INFO -  736 INFO Removed tab Tab 3
13:55:19     INFO -  737 INFO Waiting for toolbox-destroyed
13:55:19     INFO -  738 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_options_disable_cache.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - expected PASS
13:55:19     INFO -  739 INFO TEST-OK | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_options_disable_cache.js | took 46199ms
13:55:19     INFO -  ++DOCSHELL 0x864a8400 == 10 [pid = 1842] [id = 1564]
13:55:19     INFO -  ++DOMWINDOW == 26 (0x90f55760) [pid = 1842] [serial = 3736] [outer = (nil)]
13:55:19     INFO -  ++DOMWINDOW == 27 (0x90f57c30) [pid = 1842] [serial = 3737] [outer = 0x90f55760]
13:55:19     INFO -  [1842] WARNING: NS_ENSURE_TRUE(mMutable) failed: file /builds/slave/fx-team-lx-d-00000000000000000/build/netwerk/base/src/nsSimpleURI.cpp, line 265
13:55:19     INFO -  740 INFO TEST-START | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_options_disable_js.js
Looking at the logs it seems obvious that the test is simply doing too much (toggling toolboxes, reloading tabs) to finish within the given time limits on slow debug builds.

Here's a patch that splits the test into two. It does the following:
1) Move everything outside add_task to shared helper, helper_disable_cache.js
2) Split the code inside add_task such that
    - browser_toolbox_options_disable_cache-01.js asserts that disabling cache in one toolbox disables cache for all tabs that have open toolbox (lines 36-41 in the old test)
    - browser_toolbox_options_disable_cache-02.js asserts that cache is correctly disabled/enabled when toolbox is toggled (lines 43-58 in old test)

In the end the two tests perform the same checks as the current test while (hopefully) staying within time limits.

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4278520976d
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Attachment #8542668 - Flags: review?(mratcliffe)
Attachment #8542668 - Flags: review?(mratcliffe) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/8455c5f7dbb1
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/8455c5f7dbb1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: