Closed
Bug 1070444
Opened 10 years ago
Closed 10 years ago
mozilla::pkix's pkixbuild_tests uses NSS directly
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: briansmith, Assigned: briansmith)
References
Details
Attachments
(1 file)
|
12.85 KB,
patch
|
keeler
:
review+
|
Details | Diff | Splinter Review |
pkixbuild_tests.cpp is the only test that uses NSS directly. We should modify it so that it doesn't use NSS at all. To do so, we need to change the implementation of the FindIssuers function and the CERTCertificate-using code related to that, and then remove the call to NSS_NoDB_Init.
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8854de9dd30a
Comment on attachment 8540559 [details] [diff] [review] bug-1070444.patch Review of attachment 8540559 [details] [diff] [review]: ----------------------------------------------------------------- Great - thanks for taking care of this.
Attachment #8540559 -
Flags: review?(dkeeler) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f90deb1be15 Thanks for the quick review turnaround!
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2f90deb1be15
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•