Closed
Bug 1070614
Opened 10 years ago
Closed 10 years ago
Fix some TypeErrors and SyntaxErrors seen in JS strict mode when running mozmill tests
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(thunderbird36 fixed)
RESOLVED
FIXED
Thunderbird 36.0
Tracking | Status | |
---|---|---|
thunderbird36 | --- | fixed |
People
(Reporter: aceman, Assigned: aceman)
References
Details
Attachments
(3 files, 1 obsolete file)
1.33 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
3.02 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
2.21 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
JavaScript strict warning: resource:///modules/msgDBCacheManager.js, line 131: SyntaxError: in strict mode code, functions may be declared only at top level or immediately within another function JavaScript strict warning: file:///tbird-bin/dist/bin/components/imContacts.js, line 101: SyntaxError: in strict mode code, functions may be declared only at top level or imm ediately within another function JavaScript strict warning: file:///tbird-bin/dist/bin/components/nsAbAutoCompleteSearch.js, line 364: SyntaxError: in strict mode code, functions may be declared only at top level or immediately within another function JavaScript strict warning: resource://mozmill/modules/frame.js -> file:///mail/test/mozmill/tabmail/test-tabmail-dragndrop.js, line 328: TypeError: "recentlyClosedTabs" is read-only
Attachment #8492637 -
Flags: review?(florian)
Attachment #8492638 -
Flags: review?(mkmelin+mozilla)
Attachment #8492639 -
Flags: review?(neil)
Comment 4•10 years ago
|
||
Comment on attachment 8492637 [details] [diff] [review] 1070614-im Thanks!
Attachment #8492637 -
Flags: review?(florian) → review+
Small nit from Neil.
Attachment #8492639 -
Attachment is obsolete: true
Attachment #8492639 -
Flags: review?(neil)
Attachment #8492664 -
Flags: review?(neil)
Updated•10 years ago
|
Attachment #8492664 -
Flags: review?(neil) → review+
Updated•10 years ago
|
Attachment #8492638 -
Flags: review?(mkmelin+mozilla) → review+
Comment 9•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/53b401928f08 https://hg.mozilla.org/comm-central/rev/b03be9fe6acd https://hg.mozilla.org/comm-central/rev/acbcfef22bd3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
Updated•9 years ago
|
status-thunderbird36:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•