1070696 - Improve native global ergonomics a bit

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

There are various inconveniences that have been bothering me. I was going to wait until jimb's refactoring in bug 971673 was done before doing this, but that's been taking a while and this stuff is easy to fix.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Part 1 - Rename xpc::GetNativeForGlobal to xpc::NativeGlobal and make it accept non-global JSObjects. v1

The method is infallible, and making the callers invoke
js::GetGlobalForObjectCrossCompartment manually is dumb.

Comment 2

[Bobby Holley (:bholley)]

Attachment: Part 2 - Implement a JSObject* override to AutoJSAPI::Init(). v1

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8492733 [details] [diff] [review]
Part 2 - Implement a JSObject* override to AutoJSAPI::Init(). v1

>+  // This is a helper that grabs the native global associated with aGlobalObject
aObject, not aGlobalObject

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8492732 [details] [diff] [review]
Part 1 - Rename xpc::GetNativeForGlobal to xpc::NativeGlobal and make it accept non-global JSObjects. v1

> /**
>+ * Returns the nsIGlobalObject corresponding to |aObjs|'s JS global.
>+ */
>+nsIGlobalObject *
>+NativeGlobal(JSObject *aObj);

nsIGlobalObject*
NativeGlobal(JSObject* aObj);
would follow Mozilla coding style, but xpconnect has some unusual rules.

Comment 5

[Bobby Holley (:bholley)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e1f3be2c48f6
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/cafe6d84215b

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e1f3be2c48f6
https://hg.mozilla.org/mozilla-central/rev/cafe6d84215b