1071134 - Fix command line help for updater

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

For Mac v2 signing an additional command line param was added. Now it should be
fprintf(stderr, "Usage: updater patch-dir install-dir apply-to-dir [wait-pid [callback-working-dir callback-path args...]]\n");

This bug will fix that and the documentation

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: pach rev1

Comment 2

[Stephen A Pohl [:spohl]]

Comment on attachment 8493250 [details] [diff] [review]
pach rev1

Review of attachment 8493250 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/update/updater/updater.cpp
@@ +2227,5 @@
>    InitProgressUI(&argc, &argv);
>  
>    // To process an update the updater command line must at a minimum have the
> +  // directory path containing the updater.mar file to process as the first
> +  // argument the install directory as the second argument, and the directory to

nit: a comma after "[...] updater.mar file to process as the first argument" might help readability.

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch - addressed comment

Comment 4

[Robert Strong (they/them - no direct email)]

Pushed to oak
https://hg.mozilla.org/projects/oak/rev/ab7770c47443

Comment 5

[Robert Strong (they/them - no direct email)]

I've also updated the wiki
https://wiki.mozilla.org/Software_Update:Manually_Installing_a_MAR_file

Comment 6

[Robert Strong (they/them - no direct email)]

Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/818b73513ce2

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/818b73513ce2

Comment 8

[Robert Strong (they/them - no direct email)]

Landed on aurora in the Mac V2 signing combined patch in bug 1047584