1072008 - Improve spidermonkey shell builds

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Steve Fink [:sfink] [:s:]]

Mainly, I want to make these run jstests and jsapi-tests, but there are other improvements queued up too.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Run in development mode if no properties file is given

Much easier to do test runs locally with this. It no longer does stupid stuff like looking for /tools/gcc on developer runs.

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Add a --dep option for a depend build that does not blow away the objdir

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Port to msys

I tried this. It even seems to work.

Comment 4

[Steve Fink [:sfink] [:s:]]

Attachment: Use --enable-nspr-build instead of building NSPR manually

Given how much pain it was to implement --enable-nspr-build, I really ought to make use of it.

Actually, I suspect the msys build will only work with this patch applied, but I'm not sure and I don't care to find out.

Comment 5

[Steve Fink [:sfink] [:s:]]

Attachment: Run jstests and jsapi-tests on the shell builds

This was the main point of this whole exercise. I don't know of any jobs this will break (eg I don't think we do shell builds for b2g), but I guess I'll find out.

Comment 6

[Terrence Cole [:terrence]]

Comment on attachment 8494124 [details] [diff] [review]
Add a --dep option for a depend build that does not blow away the objdir

Review of attachment 8494124 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/spidermonkey_builds/spidermonkey.sh
@@ +111,5 @@
>  else
>    CONFIGURE_ARGS=$(cat $SPIDERDIR/$VARIANT)
>  fi
>  
>  # Always do clobber builds. They're fast.

Please fix the comment too.

Comment 7

[Terrence Cole [:terrence]]

Comment on attachment 8494126 [details] [diff] [review]
Use --enable-nspr-build instead of building NSPR manually

Review of attachment 8494126 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 8

[Terrence Cole [:terrence]]

Comment on attachment 8494129 [details] [diff] [review]
Run jstests and jsapi-tests on the shell builds

Review of attachment 8494129 [details] [diff] [review]:
-----------------------------------------------------------------

This will probably be exciting.

Comment 10

[Steve Fink [:sfink] [:s:]]

There is a decent chance that this will break all of the SM(...) builds because of the added tests. (They passed locally, but that only goes so far.)

http://hg.mozilla.org/build/tools/rev/d953984b2f6c
http://hg.mozilla.org/build/tools/rev/07cc11ccb05c
http://hg.mozilla.org/build/tools/rev/9a3b2019ad5d
http://hg.mozilla.org/build/tools/rev/9fb4b6a69330
http://hg.mozilla.org/build/tools/rev/044ee8c9e8fc

Comment 11

[Ed Morley [:emorley]]

07cc11ccb05c unset exec mode on scripts/spidermonkey_builds/spidermonkey.sh, which is causing:

/usr/bin/env: scripts/scripts/spidermonkey_builds/spidermonkey.sh: Permission denied

http://ftp.mozilla.org/pub/mozilla.org/spidermonkey/try-builds/[e-mail]-61c874da1e3c/try-linux-debug/try_linux-debug_spidermonkey-arm-sim-bm76-try1-build308.txt.gz

Comment 12

[Chris Cooper [:coop] (he/him)]

(In reply to Ed Morley [:edmorley] from comment #11)
> 07cc11ccb05c unset exec mode on scripts/spidermonkey_builds/spidermonkey.sh,
> which is causing:
> 
> /usr/bin/env: scripts/scripts/spidermonkey_builds/spidermonkey.sh:
> Permission denied
> 
> http://ftp.mozilla.org/pub/mozilla.org/spidermonkey/try-builds/
> [e-mail]-61c874da1e3c/try-linux-debug/try_linux-
> debug_spidermonkey-arm-sim-bm76-try1-build308.txt.gz

Fixed:

https://hg.mozilla.org/build/tools/rev/690e81485930

Comment 13

[Steve Fink [:sfink] [:s:]]

Attachment: Make check-jstests actually run tests

This one shouldn't actually land until we decide what tests we really want to run. This would be a big and slow addition to all these jobs. Discussion on IRC is tending towards identifying the slowest tests and not running them with the interpreter. (Perhaps in addition to --skip-slow we could add --skip-interpreted-slow or something.)

Comment 14

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8495582 [details] [diff] [review]
Make check-jstests actually run tests

Review of attachment 8495582 [details] [diff] [review]:
-----------------------------------------------------------------

This ended up getting done in a separate bug.

Comment 15

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.