Closed Bug 1072118 Opened 10 years ago Closed 10 years ago

Uncaught promise rejection from gmpInstallManager.simpleCheckAndInstall()

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 35

People

(Reporter: mossop, Assigned: mossop)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
We may not care about doing anything with the promise rejection but simpleCheckAndInstall already logs a sane error message, we don't need the log spew caused by the uncaught promise rejection, particularly since this can cause test failures in some harnesses.
Attachment #8494265 - Flags: review?(netzen)
Assignee: nobody → dtownsend+bugmail
Status: NEW → ASSIGNED
Comment on attachment 8494265 [details] [diff] [review]
patch

Review of attachment 8494265 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I wasn't aware that we logged unfulfilled promise rejections.
Attachment #8494265 - Flags: review?(netzen) → review+
https://hg.mozilla.org/mozilla-central/rev/8bc7b34bd8ec
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: