Closed
Bug 1072696
Opened 10 years ago
Closed 10 years ago
Do not leak debugScopes if init fails
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: terrence, Assigned: terrence)
Details
Attachments
(1 file)
|
1.02 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
If we do not free and clear debugScopes after DebugScopes::init fails, then we will try to sweep debugScopes, but the liveScopes and missingScopes tables may not be initialized. I did not actually encounter this issue, just noticed it when debugging something else.
Attachment #8494886 -
Flags: review?(jcoppeard)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8494886 [details] [diff] [review] fix_debugScopes_init_leak-v0.diff Review of attachment 8494886 [details] [diff] [review]: ----------------------------------------------------------------- Nice catch.
Attachment #8494886 -
Flags: review?(jcoppeard) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e0e2eacb900
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5e0e2eacb900
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•