Closed
Bug 1072860
Opened 10 years ago
Closed 10 years ago
modernize nshttptransaction.cpp ptrs and asserts
Categories
(Core :: Networking: HTTP, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: mcmanus, Assigned: mcmanus)
Details
Attachments
(1 file)
6.94 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
use smart pointers and assert that Connection() is only called on the socket thread
Assignee | ||
Comment 1•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=bbc61571ee24
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8495151 -
Flags: review?(valentin.gosu)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
Comment 3•10 years ago
|
||
Comment on attachment 8495151 [details] [diff] [review] modernize ref counting and thread asserts for nshttptransaction Review of attachment 8495151 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.
Attachment #8495151 -
Flags: review?(valentin.gosu) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b75d671af47
I had to back this out for b2g mochitest-3 failures: https://hg.mozilla.org/integration/mozilla-inbound/rev/630e46998956 https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2569512&repo=mozilla-inbound
Flags: needinfo?(mcmanus)
Comment 6•10 years ago
|
||
That failure seems unrelated to this patch. The next few pushes were green, so this is likely the intermittent orange from Bug 1054124 comment 83 (same stack and test)
Flags: needinfo?(kwierso)
Yeah, that seems likely.
Flags: needinfo?(kwierso)
Assignee | ||
Comment 8•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=99e24a19bfd6 has the same test failure and its after the backout. so I'll repush this when I get to my desk for the day
Flags: needinfo?(mcmanus)
Assignee | ||
Comment 9•10 years ago
|
||
back in the tree https://hg.mozilla.org/integration/mozilla-inbound/rev/998a7adb3d9c
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/998a7adb3d9c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•