1073398 - [Browser]Share button is disabled if the activity(Email) is not closed

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[vsireesha246]

STR:

Browser - youtube - Share - E-mail - Attach - Music - Random music select - Play - Home key press - open Browser

Actual:Share button is disabled

Expected:Share button should be active

Comment 1

[vsireesha246]

In V2.0 this is due to handleShareButtonClick() implementation

We are enabling the 'Share' button activity.onsuccess and activity.onerror case.
If the activity is in background we will not get these functions,so the 'Share' is in disabled state.

Is there any specific reason to do this.Actually we are restricting the use by disabling the 'Share'.

Asking need info to Yliao on this.

Comment 2

[vsireesha246]

As per IRC chat with Ben the share is disabled due to this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1011611

Need to check for a workaround 'onvisibilitychange' event we can re-enable the 'Share' button.

Thanks..
Sireesha

Comment 3

[vsireesha246]

Attachment: V2.0 Bug_1073398.patch

Hi Ben,

Would you please review the attached patch and let me know your review comments.
If you are fine with this patch i will create PR for the same.

Thanks..
Sireesha

Comment 4

[Ben Francis [:benfrancis]]

Comment on attachment 8496687 [details] [diff] [review]
V2.0 Bug_1073398.patch

Review of attachment 8496687 [details] [diff] [review]:
-----------------------------------------------------------------

This looks OK to me, thanks.

Is this a 2.1 blocker? Just a reminder that the browser app is about to be deleted in master in bug 1043959.

Comment 5

[BMO Automation]

Firefox OS is not being worked on