Closed Bug 1073502 Opened 10 years ago Closed 10 years ago

Sessions with an empty set of windows don't restore closed windows on start

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Type:
defect
Priority:
Not set
Severity:
normal
Points:
2

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 35
Iteration:
35.2
Tracking Flags:
Tracking Status
firefox32 --- wontfix
firefox33 --- verified
firefox34 + verified
firefox35 + verified

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

Attachments

(1 file)

0001-Bug-1020831-Restore-closed-windows-even-when-there-a.patch
2.16 KB, patch
Yoric
: review+
Sylvestre
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review 
In bug 1020831 we ended up with an empty set of windows on Linux/Windows. On Mac this is easily doable by closing windows one-by-one and hitting Cmd-Q. In both of those cases (although the first one shouldn't actually happen) we should at least restore the list of closed windows to recover a little easier.
Iteration: --- → 35.2
Points: --- → 2
QA Whiteboard: [qa+]
Flags: firefox-backlog+
QA Whiteboard: [qa+]
Flags: qe-verify+
Comment on attachment 8495914 [details] [diff] [review]
0001-Bug-1020831-Restore-closed-windows-even-when-there-a.patch

Review of attachment 8495914 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch/cleanup.
Attachment #8495914 - Flags: review?(dteller) → review+
[Tracking Requested - why for this release]:

Due to the complexity of its patch we're not taking bug 1020831 for 33. I would like to instead uplift this patch as it's quite small and safe and would help users recover from bug 1020831 easier by at least being able to manually restore closed windows.
status-firefox32: --- → wontfix
status-firefox33: --- → affected
status-firefox34: --- → affected
tracking-firefox33: --- → ?
tracking-firefox34: --- → ?
https://hg.mozilla.org/mozilla-central/rev/8c8c22fd608d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox35: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Verified fixed using latest Nightly, build ID: 20140930030202.
Status: RESOLVED → VERIFIED
status-firefox35: fixed → verified
Comment on attachment 8495914 [details] [diff] [review]
0001-Bug-1020831-Restore-closed-windows-even-when-there-a.patch

Approval Request Comment
[Feature/regressing bug #]: 
[User impact if declined]: Users hitting bug 1020831 (that won't be uplifted to Beta) will be able to recover a little more easily with the patch here.
[Describe test coverage new/current, TBPL]: Somewhat covered by existing tests but unfortunately no test specific to this issue - we can't test the startup path :/
[Risks and why]: Risk is low.
[String/UUID change made/needed]: None.
Attachment #8495914 - Flags: approval-mozilla-beta?
Attachment #8495914 - Flags: approval-mozilla-aurora?
Attachment #8495914 - Flags: approval-mozilla-beta?
Attachment #8495914 - Flags: approval-mozilla-beta+
Attachment #8495914 - Flags: approval-mozilla-aurora?
Attachment #8495914 - Flags: approval-mozilla-aurora+
QA Contact: cornel.ionce
Tested and verified this issue using latest Firefox Aurora, build ID: 20141006004057 and Firefox 33 beta 9, build ID: 20141002185629.
status-firefox33: fixed → verified
status-firefox34: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: