1073771 - SM(arm) builds are broken on Beta33 and Aurora34

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Same error for both. Nah, we don't need to be running these builds on the release branches...

https://tbpl.mozilla.org/php/getParsedLog.php?id=49017324&tree=Try

Linux try leak test spidermonkey_try-arm-sim build on 2014-09-26 17:39:59 PDT for push 7951977b3edf
slave: b-linux64-hp-0001

/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp:55:8: error: 'JitCode' does not name a type
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp: In member function 'virtual bool cls_testJitMoveEmitterCycles_simple::run(JS::HandleObject)':
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp:94:46: error: 'linkAndAllocate' was not declared in this scope
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp:70:17: warning: unused variable 'jrt' [-Wunused-variable]
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp: In member function 'virtual bool cls_testJitMoveEmitterCycles_autogen::run(JS::HandleObject)':
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp:174:46: error: 'linkAndAllocate' was not declared in this scope
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp:112:17: warning: unused variable 'jrt' [-Wunused-variable]
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp: In member function 'virtual bool cls_testJitMoveEmitterCycles_autogen2::run(JS::HandleObject)':
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp:283:46: error: 'linkAndAllocate' was not declared in this scope
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp:213:17: warning: unused variable 'jrt' [-Wunused-variable]
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp: In member function 'virtual bool cls_testJitMoveEmitterCycles_autogen3::run(JS::HandleObject)':
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp:397:46: error: 'linkAndAllocate' was not declared in this scope
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp:327:17: warning: unused variable 'jrt' [-Wunused-variable]

Comment 1

[Marty Rosenberg [:mjrosenb]]

Attachment: fixBuildFailures-r0.patch

Probably overkill, but this made it build locally.

Comment 2

[Marty Rosenberg [:mjrosenb]]

https://tbpl.mozilla.org/?tree=Try&rev=0ce7d3da23ee

Comment 3

[Douglas Crosher [:dougc]]

Comment on attachment 8496388 [details] [diff] [review]
fixBuildFailures-r0.patch

Review of attachment 8496388 [details] [diff] [review]:
-----------------------------------------------------------------

If the test passes then it looks good.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Thanks for the quick fix!

https://hg.mozilla.org/integration/mozilla-inbound/rev/a1fb032b0216
https://hg.mozilla.org/releases/mozilla-aurora/rev/0f1e37627803
https://hg.mozilla.org/releases/mozilla-beta/rev/97feda79279e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

This is still hitting failures on my Aurora-As-Beta push:

https://tbpl.mozilla.org/php/getParsedLog.php?id=49047199&tree=Try#error0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Oh, comment 5 was apparently straight-up bustage on trunk and Aurora. Note that beta is green, though. I've backed out the original patch from inbound. I'll land a follow-up fix on Aurora based on whatever revised patch comes next since the jobs don't run by default there anyway.

https://hg.mozilla.org/integration/mozilla-inbound/rev/deb7b678cc9e

Comment 7

[Marty Rosenberg [:mjrosenb]]

Sanity check: You don't need any more patches from me, correct?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Trunk and Aurora were both hitting the bustage in comment 5. I had to back it out from inbound as a result. So this bug is only fixed on beta at the moment.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

For 34/35, is it as simple as just using ION_CODE instead of JSC::ION_CODE? IIRC, most of the JSC stuff was removed in the 34 timeframe.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Testing that theory:
https://tbpl.mozilla.org/?tree=Try&rev=8f66dad49fbb

Comment 11

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #10)
> Testing that theory:
> https://tbpl.mozilla.org/?tree=Try&rev=8f66dad49fbb

Indeed :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/76ab08438176
https://hg.mozilla.org/releases/mozilla-aurora/rev/4e0bde619641

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/76ab08438176