1073855 - browser_datareporting_notification.js is going to perma-fail when Gecko 35 merges to Aurora

Status: VERIFIED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Guessing this is fallout from bug 1063696. Merge day is two weeks out, so please look at this ASAP.

https://tbpl.mozilla.org/php/getParsedLog.php?id=49027710&tree=Try

20:26:16     INFO -  392 INFO TEST-START | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js
20:26:16     INFO -  1411788376388	Services.DataReporting.Policy	DEBUG	Setting first-run date: Fri Sep 26 2014 20:26:16 GMT-0700 (PDT)
20:26:16     INFO -  1411788376390	Services.DataReporting.Policy	DEBUG	Setting first-run date: Thu Sep 25 2014 20:26:16 GMT-0700 (PDT)
20:26:16     INFO -  1411788376393	Services.DataReporting.Policy	INFO	Requesting display of data policy.
20:26:16     INFO -  1411788376394	Services.DataReporting.InfoBar	INFO	Creating data reporting policy notification.
20:26:16     INFO -  1411788376401	Services.DataReporting.Policy	DEBUG	Recording data policy notification to version 1 on date Fri Sep 26 2014 20:26:16 GMT-0700 (PDT)
20:26:16     INFO -  1411788376401	Services.DataReporting.Policy	DEBUG	Setting user notified date: Fri Sep 26 2014 20:26:16 GMT-0700 (PDT)
20:26:16     INFO -  1411788376962	Sync.Status	DEBUG	Status.login: error.login.reason.no_username => error.login.reason.no_username
20:26:16     INFO -  1411788376969	Sync.Status	DEBUG	Status.service: service.client_not_configured => service.client_not_configured
20:26:17     INFO -  1411788377069	Sqlite.Connection.places.sqlite#1: 	TRACE	undefinedStmt #498 INSERT OR REPLACE INTO moz_openpages_temp (url, open_count)
20:26:17     INFO -           VALUES ( :url, IFNULL( (SELECT open_count + 1
20:26:17     INFO -                                    FROM moz_openpages_temp
20:26:17     INFO -                                    WHERE url = :url),
20:26:17     INFO -                                    1
20:26:17     INFO -                                )
20:26:17     INFO -                  ) - {"url":"about:home"}
20:26:17     INFO -  1411788377124	Sqlite.Connection.places.sqlite#0: 	TRACE	undefinedStmt #272 SELECT b.id FROM moz_bookmarks b
20:26:17     INFO -                           JOIN moz_places h on h.id = b.fk
20:26:17     INFO -                           WHERE h.url = :url - {"url":"about:home"}
20:26:17     INFO -  1411788377141	Services.DataReporting.Policy	DEBUG	Setting first-run date: Fri Sep 26 2014 20:26:17 GMT-0700 (PDT)
20:26:17     INFO -  1411788377145	Services.DataReporting.Policy	DEBUG	Setting first-run date: Thu Sep 25 2014 20:26:17 GMT-0700 (PDT)
20:26:17     INFO -  1411788377160	Sqlite.Connection.places.sqlite#1: 	DEBUG	undefinedStmt #498 finished.
20:26:17     INFO -  1411788377173	Services.DataReporting.Policy	INFO	Requesting display of data policy.
20:26:17     INFO -  1411788377174	Services.DataReporting.InfoBar	INFO	Creating data reporting policy notification.
20:26:17     INFO -  1411788377179	Services.DataReporting.InfoBar	INFO	Creating data reporting policy notification.
20:26:17     INFO -  1411788377184	Services.DataReporting.Policy	DEBUG	Recording data policy notification to version 1 on date Fri Sep 26 2014 20:26:17 GMT-0700 (PDT)
20:26:17     INFO -  1411788377185	Services.DataReporting.Policy	DEBUG	Setting user notified date: Fri Sep 26 2014 20:26:17 GMT-0700 (PDT)
20:26:17     INFO -  1411788377187	Sqlite.Connection.places.sqlite#0: 	DEBUG	undefinedStmt #272 finished.
20:26:17     INFO -  1411788377586	Services.DataReporting.InfoBar	DEBUG	Closing notification.
20:26:17     INFO -  Not finishing test yet because pref pane hasn't yet appeared.
20:26:17     INFO -  Finishing multiple window test.
20:26:17     INFO -  393 INFO TEST-OK | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | took 1558ms
20:26:17     INFO -  dumping last 1 message(s)
20:26:17     INFO -  if you need more context, please use SimpleTest.requestCompleteLog() in your test
20:26:17     INFO -  394 INFO checking window state
20:26:17     INFO -  395 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_datareporting_notification.js | Found an unexpected Browser:Preferences at the end of test run - expected PASS

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-1073855-fix-browser_datareporting_notification-t.patch

Sorry, this is my fault - I keep forgetting incontent prefs aren't riding the trains yet :(  When prefs are in a dialog we *do* need to close the prefs window.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/2b72cf7356e2

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2b72cf7356e2