Closed Bug 1074048 Opened 10 years ago Closed 10 years ago

Intermittent /tests/content/media/webaudio/test/test_bug875221.html | Assertion failure: lock->locked && pthread_equal(lock->owner, pthread_self())

Categories

(Core :: Audio/Video, defect, P1)

Product:
Core
Component:
Audio/Video
Version:
Other Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35
Tracking Flags:
Tracking Status
firefox33 --- unaffected
firefox34 --- fixed
firefox35 --- fixed
firefox-esr31 --- unaffected
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: jesup, Assigned: jesup)

References

Details

(Keywords: intermittent-failure, Whiteboard: [webrtc-uplift])

Attachments

(1 file, 1 obsolete file)

Allow MainThread access if the graph is shut down (for RunDuringShutdown)
2.72 KB, patch
roc
: review+
lmandel
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Likely will happen randomly across tests...  debug only assertion

This could be wallpapered by allowing RunDuringShutdown() to bypass the thread-safety locks (added in bug 1072775).  However, that's not likely safe.  If we could guarantee that all RunDuringShutdown calls were on one thread, then it would be (probably) safe, but we can't.

Assertion failure: lock->locked && pthread_equal(lock->owner, pthread_self()), at /builds/slave/m-in-lx-d-00000000000000000000/build/nsprpub/pr/src/pthreads/ptsynch.c:226
Assertion failure: lock->locked && pthread_equal(lock->owner, pthread_self()), at /builds/slave/m-in-lx-d-00000000000000000000/build/nsprpub/pr/src/pthreads/ptsynch.c:226
> This could be wallpapered by allowing RunDuringShutdown() to bypass the
> thread-safety locks (added in bug 1072775).  However, that's not likely
> safe.  If we could guarantee that all RunDuringShutdown calls were on one
> thread, then it would be (probably) safe, but we can't.

Never mind, karlt pointed out to me that AppendMessage() is MainThread-only, so I just need to let it bypass the locks....
Attachment #8496683 - Attachment is obsolete: true
Comment on attachment 8496685 [details] [diff] [review]
Allow MainThread access if the graph is shut down (for RunDuringShutdown)

I can integrate the ! into the parenthetical if you want; I left it that way because I found I could read it as "if (!(inRunDuringShutdown))"
Attachment #8496685 - Flags: review?(roc)
Assignee: nobody → rjesup
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/e22cabe63a98
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
We'll need this on Aurora once the other bugs get uplifted.
status-firefox33: --- → unaffected
status-firefox34: --- → affected
status-firefox35: --- → fixed
status-firefox-esr31: --- → unaffected
Whiteboard: [webrtc-uplift]
Comment on attachment 8496685 [details] [diff] [review]
Allow MainThread access if the graph is shut down (for RunDuringShutdown)

Approval Request Comment
[Feature/regressing bug #]: bug 1072775 (should uplift with it)

[User impact if declined]: Random oranges/ASSERTs in debug builds

[Describe test coverage new/current, TBPL]: all TBPL media tests

[Risks and why]: minimal risk; relaxing new thread-safety assertion to allow the shutdown mode.

[String/UUID change made/needed]: none
Attachment #8496685 - Flags: approval-mozilla-aurora?
Blocks: 1072775
Comment on attachment 8496685 [details] [diff] [review]
Allow MainThread access if the graph is shut down (for RunDuringShutdown)

Aurora+
Attachment #8496685 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: