1074070 - [Settings] Unify HTML mark style in Display and Sound panels

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Manuel Casas Barrado [:mancas]]

We should include the sound icons to the gaia-icons repo and use them instead of background images as we currently do in Display panel.

Expected HTML:

<label class="range-icons">
    <span data-icon="volume-media-sound"></span>
    <input type="range" step="1" min="0" value="8" max="15">
</label>

Comment 1

[Carol Huang [:Carol]]

Hi Manuel,
I'm not handling Setting right now. 
I can help you pin to the person who's taking care of Settingm but I need more clue about it.
Do you have screenshots or anything to explain what this is about?
Thanks!

Comment 2

[Manuel Casas Barrado [:mancas]]

Attachment: icons-sound-panel.png

Hi Carol,

The aim here is to have the same HTML structure as we use in Display Panel (see icons in attachment: icons-display-panel.png). The icons you see in the display panel are added in the gaia-icons font. However, the other ones you see in sound panel (see attachment:icons-sound-panel.png) are not included.

So I need the svg files of these icons to be included in the gaia-icons font repository and then I will take care of changing the HTML structure.

I hope it will be helpful

Comment 3

[Manuel Casas Barrado [:mancas]]

Attachment: icons-display-panel.png

Comment 4

[Carol Huang [:Carol]]

Hi Helen,
Please provide the files that Manuel needs, thank you!

Comment 5

[Helen Huang [:HHuang]]

Attachment: SVGs.zip

Update 'ringer-volume' and 'alarm-volume' icons in SVG format, besides, I found we already have 'sound-max' icon in Gaia-icon that can be used for media volume.

Comment 6

[Manuel Casas Barrado [:mancas]]

Attachment: Patch

Comment 7

[Manuel Casas Barrado [:mancas]]

Attachment: sound-panel.png

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8511872 [details] [review]
Patch

Looks good to me! Could you also remove the image files as they are no longer used? Thanks.

Comment 9

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8511872 [details] [review]
Patch

I've deleted the images. Please, could you check that everything it's ok?
Thanks!

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8511872 [details] [review]
Patch

r=me, thank you!

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: 1f1745c6309c199c9f0ff4b17eb1a55a1f40ee96