1074156 - Add support for content sandbox tests to TBPL

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Bob Owen (:bobowen)]

Bug 1074147 is adding plain mochitests running with the content sandbox for win32 on holly.

This is to add support to tpbl for these new tests similar to the e10s ones.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Happy mentor you on this if you need pointers, but yeah, you should be able to follow the same pattern as the e10s tests.

Comment 2

[Bob Owen (:bobowen)]

Attachment: Add new content sandbox mochitest group v1

I've just added these for the plain mochitests at the moment, didn't think it was worth adding for the others as we may not use it and it looks like treeherder will be taking over pretty soon.

Which reminds me I need to raise that bug. :)

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8498151 [details] [diff] [review]
Add new content sandbox mochitest group v1

Review of attachment 8498151 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming you've tested it locally and confirmed that nothing breaks as-is :). Thanks for the patch!

::: js/Config.js
@@ +301,5 @@
>      "Mochitest e10s": ["Mochitest e10s",
>                         "Mochitest e10s Browser Chrome",
>                         "Mochitest e10s DevTools Browser Chrome",
>                         "Mochitest e10s Other"],
> +    "Mochitest csb": ["Mochitest csb"],

Above the e10s group.

@@ +502,5 @@
>      "Mochitest e10s" : "M-e10s",
>      "Mochitest e10s Browser Chrome" : "bc",
>      "Mochitest e10s DevTools Browser Chrome" : "dt",
>      "Mochitest e10s Other" : "oth",
> +    "Mochitest csb" : "M-csb",

This means they will display in the UI after the M-e10s group. That's probably for the best so the UI is more consistent (all the M-e10s groups roughly in line with each other). So let's leave this as-is for now.

::: js/Data.js
@@ +641,5 @@
>          /mochitest-e10s-browser-chrome/i.test(name) ? "Mochitest e10s Browser Chrome" :
>          /mochitest-e10s-devtools-chrome/i.test(name) ? "Mochitest e10s DevTools Browser Chrome" :
>          /mochitest-e10s-other/i.test(name) ? "Mochitest e10s Other" :
>          /mochitest-e10s/i.test(name) ? "Mochitest e10s" :
> +        /mochitest-csb/i.test(name) ? "Mochitest csb" :

Put this above the e10s lines.

Comment 4

[Bob Owen (:bobowen)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #3)

> r=me assuming you've tested it locally and confirmed that nothing breaks
> as-is :). Thanks for the patch!

Thanks.
Yes, I've tried this locally against various trees. :)

I've made the changes from your review locally.
I was going to wait until the jobs were running on holly, so I could make sure the M-csb jobs appear before landing this.

Comment 5

[Bob Owen (:bobowen)]

Attachment: Add new content sandbox mochitest group v2

r=RyanVM - from comment 3

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #3)
> Comment on attachment 8498151 [details] [diff] [review]
> Add new content sandbox mochitest group v1
> 
> Review of attachment 8498151 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me assuming you've tested it locally and confirmed that nothing breaks
> as-is :). Thanks for the patch!

> >                         "Mochitest e10s Other"],
> > +    "Mochitest csb": ["Mochitest csb"],
> 
> Above the e10s group.

Moved.
 
> >          /mochitest-e10s/i.test(name) ? "Mochitest e10s" :
> > +        /mochitest-csb/i.test(name) ? "Mochitest csb" :
> 
> Put this above the e10s lines.

Moved.

Comment 6

[Bob Owen (:bobowen)]

Landed on default: https://hg.mozilla.org/webtools/tbpl/rev/99f7932ac9c7

Comment 7

[Ryan VanderMeulen [:RyanVM]]

In production :)