1074332 - [Utility Tray] Status Bar icons toggle off/on to soon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Eric Pang [:epang] UX]

Attachment: Ambient_Indicator_Tray_opening_flow.jpg

Hi Alberto,

I'm opening this bug as a follow up to bug 1067913.
Currently with the patch in bug 1067913 the status bar icons toggle off before the handle passes with the vice versa happening when the tray goes up.

I've attached a visual flow of what ideally should happen.
If you have any questions please let me know, thanks!

Comment 2

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26189

Eric, could you please ui-review this?

Thanks!

Comment 3

[Eric Pang [:epang] UX]

Comment on attachment 8523812 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26189

Hey Alberto, this is looking really good but I think a few tweaks are needed.

1. Is it possible to have the handle of the utility tray full opaicty all the way though?  I think it will help with the transition.

2.  When pulling down the handle at the top it feels a little jagged. Right after you see the entire handle it feels like it snaps down.  Is there anything we can do to make this smoother?

3. When you close the tray the date/icons shouldn't move up.  It looks cool, but the icons end up flashing back that are under the tray.  This only happens when you you flick the tray closed - if you hold you're finger down it doesn't happen.

Let me know if you have any questions or if I need to clarify :).  This is looking great so far!!  Flag more for review again when ready and feel free to bug me!

Comment 4

[Alberto Pastor [:albertopq]]

Comment on attachment 8523812 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26189

Hi Eric. I just updated the patch, and now 1 and 3 should be fixed. Regarding 2, couldn't find an easy way of making it smoother (we are showing/hiding the real statusbar when that happens, so moving only in that space is not cheap). I'll ask for advice on the review for that.

Thanks!

Comment 5

[Eric Pang [:epang] UX]

Comment on attachment 8523812 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26189

This is great, thanks for working on this Alberto :).  It also seems pretty smooth to me - have you updated the patch since yesterday? R+

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8523812 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26189

Looking real good on the phone! I had a couple of questions on github, please reflag me when you answer/address those.

Comment 8

[Alberto Pastor [:albertopq]]

Comment on attachment 8523812 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26189

I updated the PR with some fixes and also replied to the comments. Could you please re-check? Thanks!

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8523812 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26189

Looks good! Left a couple of tiny comments on github. Also, we should probably have an integration test for protecting the statusbar icon states when toggling the utility tray.

Comment 10

[Alberto Pastor [:albertopq]]

Added integration tests and fixed comments.

master: https://github.com/mozilla-b2g/gaia/commit/8654a14cd4a790484603fded2566367eca6cbeb6

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Backed out for making test_quick_settings.py permafail on OSX.
Master: https://github.com/mozilla-b2g/gaia/commit/3d72b41ba36829fd5f37ad8d076a6af45b9ad6ee

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=1002619&repo=b2g-inbound

Comment 12

[Alberto Pastor [:albertopq]]

Sorry, everything was green when I checked in:

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=180beee9b5b3

I'll take a look. Thanks!

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Looks like the failure rate is ~40% based on the retriggers I've done.

Comment 14

[Alberto Pastor [:albertopq]]

Relanded with tests fix:

master: https://github.com/mozilla-b2g/gaia/commit/a1ec2268e7b467aa0ff07a2a3cbd1b9abc4e4dd1